Added support for multiple instances in the same view#21
Open
DeKi90 wants to merge 2 commits intoBusinessOptics:masterfrom
Open
Added support for multiple instances in the same view#21DeKi90 wants to merge 2 commits intoBusinessOptics:masterfrom
DeKi90 wants to merge 2 commits intoBusinessOptics:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had been having issues with multiple instances of your really neat component in the same app, because the refence by class would always only update one graph my app with multiple graphs side by side wouldn't render one of them.
The fix is to define an ID for the graph element in each component and pass that to d3.select.