Skip to content

Feature/fix slack tasks#129

Closed
poespas wants to merge 4 commits intoByteInternet:masterfrom
poespas:feature/fix_slack_tasks
Closed

Feature/fix slack tasks#129
poespas wants to merge 4 commits intoByteInternet:masterfrom
poespas:feature/fix_slack_tasks

Conversation

@poespas
Copy link
Collaborator

@poespas poespas commented Jan 7, 2025 

$configuration->setPlatformConfigurations([
    new \Hypernode\DeployConfiguration\AfterDeployTask\SlackWebhook('https://hooks.slack.com/services/aaa/bbb/ccc'),
]);

poespas
poespas commented Jan 7, 2025
View reviewed changes
src/Stdlib/ReleaseInfo.php
public function getCommitSha(): string
{
return runLocally('git rev-parse HEAD');
try {
Copy link
Collaborator Author

@poespas poespas Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case it's not ran in a git folder

poespas
poespas commented Jan 7, 2025
View reviewed changes
src/Deployer/Task/After/SlackTask.php
public function configureWithTaskConfig(TaskConfigurationInterface $config): ?Task
{
$this->recipeLoader->load('slack.php');
$this->recipeLoader->load('../contrib/slack.php');
Copy link
Collaborator Author

@poespas poespas Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking it moved in a more recent Deployer version?

Jonathan Visser added 2 commits January 7, 2025 16:16
@poespas poespas closed this by deleting the head repository Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@poespas