Merit correction with globe by jonasjucker · Pull Request #377 · C2SM/extpar

jonasjucker · 2025-02-28T11:39:16Z

No description provided.

jonasjucker · 2025-02-28T11:39:27Z

launch jenkins

jonasjucker · 2025-03-04T10:50:11Z

@jhelmert Please make sure all tests pass:

=== testsuite.out BEGIN ===
[------------] TESTSUITE 2.1
               Parsing XML (testlist_cosmo.xml)
               Creating directory for c7_globe
               Fetching executable /scratch/b/b381001/workspace/ExtPar/extpar_pr/c9ed6753/test/testsuite/run_extpar_cosmo.sh
               Modify namelists (according to XML specification)
               
[------------] TEST mch/c7_globe: COSMO7, GLOBE input 
               Starting test
               Executing: ./run_extpar_cosmo.sh
*** ERROR: Error with system command: ./run_extpar_cosmo.sh
[   CRASH    ] RESULT mch/c7_globe: COSMO7, GLOBE input 
[------------] FINISHED
[------------] TESTSUITE 2.1
               Parsing XML (testlist_icon.xml)
               Creating directory for icon_d2
               Fetching executable /scratch/b/b381001/workspace/ExtPar/extpar_pr/c9ed6753/test/testsuite/run_extpar_icon.sh
               Modify namelists (according to XML specification)
               
[------------] TEST dwd/icon_d2: GLOBE input, icon_d2 
               Starting test
               Executing: ./run_extpar_icon.sh
*** ERROR: Error with system command: ./run_extpar_icon.sh
[   CRASH    ] RESULT dwd/icon_d2: GLOBE input, icon_d2 
[------------] FINISHED
[------------] TESTSUITE 2.1
               Parsing XML (testlist_landuse.xml)
               Creating directory for ecoclimap_sg
               Fetching executable /scratch/b/b381001/workspace/ExtPar/extpar_pr/c9ed6753/test/testsuite/run_extpar_icon.sh
               Modify namelists (according to XML specification)
               
[------------] TEST clm/ecoclimap_sg: Ecoclimap-SG landuse, Bolivia 
               Starting test
               Executing: ./run_extpar_icon.sh
*** ERROR: Error with system command: ./run_extpar_icon.sh
[   CRASH    ] RESULT clm/ecoclimap_sg: Ecoclimap-SG landuse, Bolivia 
[------------] FINISHED
[------------] TESTSUITE 2.1
               Parsing XML (testlist_art.xml)
               Creating directory for hwsd_art
               Fetching executable /scratch/b/b381001/workspace/ExtPar/extpar_pr/c9ed6753/test/testsuite/run_extpar_icon.sh
               Modify namelists (according to XML specification)
               
[------------] TEST dwd/hwsd_art: HWSD-ART
               Starting test
               Executing: ./run_extpar_icon.sh
               Test finished
  [  MATCH   ] existence_extpar_out.sh
[   MATCH    ] RESULT dwd/hwsd_art: HWSD-ART
[------------] FINISHED
=== testsuite.out END ===

Currently there are many crashes occuring. So something with the changes is not right.

jonasjucker · 2025-03-05T10:44:49Z

@jhelmert If you need any support with the PR let me know.

jhelmert · 2025-03-06T08:28:54Z

@jhelmert If you need any support with the PR let me know.

It seems that the case that only GLOBE orography is used is missing. I will add this feature.

jonasjucker · 2025-03-19T07:37:13Z

@jhelmert I wanted to highlight that next week will be my last at C2SM. Therefore it would be good to have something to review until beginning of next week.
Is that possible for you?
ping @stelliom

jhelmert · 2025-03-19T10:25:14Z

@jhelmert I wanted to highlight that next week will be my last at C2SM. Therefore it would be good to have something to review until beginning of next week. Is that possible for you? ping @stelliom

@jonasjucker Thank you Jonas. Due to ICCARUS and urgent requests for other EXTPAR issues (glaciers in Antarctica and FR_LAKE in Amazonas) there is a delay in the processing of this MR. I will do my best, but I have tomorrow a full day seminar on hi-res national soil data, so it seems unrealistic for solving the MR until beginning of next week. Thank you very much for your work and your support.

stelliom · 2025-04-29T09:52:42Z

Hi @jhelmert,

What is the status of this PR? I think this is required as soon as possible in order to support your setups on Zonda.

Cheers,
Mikael

jhelmert · 2025-05-06T09:51:42Z

Hi @jhelmert,

What is the status of this PR? I think this is required as soon as possible in order to support your setups on Zonda.

Cheers, Mikael

Dear Mikael, could you please check the recent adaptions made in the branch. I tested the modifications at DWD and it worked so far.
Thank you.
Jürgen

stelliom · 2025-05-09T10:29:47Z

Ok, I will launch the CI pipeline to check if there are any tests that fail.

stelliom · 2025-05-09T10:29:55Z

launch jenkins

stelliom · 2025-05-12T12:55:48Z

Hi @jhelmert,

Sadly the CI fails because it cannot find some data that was moved when Jonas left, could you please update your branch with the current master. I would have done it myself, but there are conflicts and I want to make sure I don't break anything for you.

…g INPUT_ORO_X

jhelmert · 2025-05-16T12:39:22Z

Hi @jhelmert,

Sadly the CI fails because it cannot find some data that was moved when Jonas left, could you please update your branch with the current master. I would have done it myself, but there are conflicts and I want to make sure I don't break anything for you.

Dear Mikael,
I have performed a rebase with origin/master and tested the updated branch with GLOBE alone, MERIT alone and a combination of MERIT and GLOBE. Could you please try the CI pipeline again?
Thank you in advance
Jürgen

stelliom · 2025-05-26T12:26:53Z

launch jenkins

stelliom · 2025-05-26T12:50:58Z

Hi @jhelmert ,

Sorry for the late answer, I did not get notified for your message. So, I just ran the CI, but I still see that there are crashes in some test cases.

[------------] TESTSUITE 2.1
               Parsing XML (testlist_cosmo.xml)
               Creating directory for c7_globe
               Fetching executable /workspace/test/testsuite/run_extpar_cosmo.sh
               Modify namelists (according to XML specification)
               
[------------] TEST mch/c7_globe: COSMO7, GLOBE input 
               Starting test
               Executing: ./run_extpar_cosmo.sh
*** ERROR: Error with system command: ./run_extpar_cosmo.sh
[   CRASH    ] RESULT mch/c7_globe: COSMO7, GLOBE input 
[------------] FINISHED
[------------] TESTSUITE 2.1
               Parsing XML (testlist_icon.xml)
               Creating directory for icon_d2
               Fetching executable /workspace/test/testsuite/run_extpar_icon.sh
               Modify namelists (according to XML specification)
               
[------------] TEST dwd/icon_d2: GLOBE input, icon_d2 
               Starting test
               Executing: ./run_extpar_icon.sh
*** ERROR: Error with system command: ./run_extpar_icon.sh
[   CRASH    ] RESULT dwd/icon_d2: GLOBE input, icon_d2 
[------------] FINISHED
[------------] TESTSUITE 2.1
               Parsing XML (testlist_landuse.xml)
               Creating directory for ecoclimap_sg
               Fetching executable /workspace/test/testsuite/run_extpar_icon.sh
               Modify namelists (according to XML specification)
               
[------------] TEST clm/ecoclimap_sg: Ecoclimap-SG landuse, Bolivia 
               Starting test
               Executing: ./run_extpar_icon.sh
*** ERROR: Error with system command: ./run_extpar_icon.sh
[   CRASH    ] RESULT clm/ecoclimap_sg: Ecoclimap-SG landuse, Bolivia 
[------------] FINISHED
testsuite did not complete successfully
Untagged: localhost/extpar:377
Deleted: ec8edb50455fb2be16a35da9f9b38685e5fd65ad5b4a1f8323173df15c8fd75b
Deleted: c4392402bd23f09e4e94da9359854bee4c6009e0b706642f81662800ee7d2e0d
Deleted: 63547aa2fc84180cebd8f7dc8d361b69571b9a6b02f43820a521765d2b05d136
Deleted: 1e8e31adc58a27f61d56fdabdb01271440e1f5f735343d0a453b51fc1adcbcd6
Deleted: 8928dbea2045133ddf62573c569f9115164f2778c9706a401db7b866bc0fbf9f
Deleted: 6ebd695f5d86cbdd7700d954f89e3826d436647c00b12fb63c530de86991f6ba
Deleted: 600832ab253e00bed9fde59befcbedb564de11767b7f2b204efaf8ae4a7f5db4
Build step 'Execute shell' marked build as failure
Notifying upstream projects of job completion
Finished: FAILURE

For easier debugging you could try to run the testsuite locally, would you like me to help you doing that?

stelliom · 2025-07-22T12:36:49Z

Hi @jhelmert,

Sorry for the late reply. I promised to give you a step-by-step guide on how to run the testsuite manually, but in the end I figured it would be better to give users a way to inspect the results of the testsuite directly from their PR. Otherwise, I would have needed to provide this guide to everyone and to make sure it works for every machine.

I am finally done implementing support for inspecting the results of the testsuite. To do this you can follow these steps:

Update your branch with the master branch. E.g. git checkout merit_scripts && git pull && git merge origin/master or whatever other way you prefer.
Write "launch jenkins(debug)" in a comment on this PR and wait for the testsuite to complete.
Once the testsuite completes you will get a URL where you can inspect the testsuite output (testsuite.out) and the logfiles and namelists of the individual tests.

BTW, I used this PR as a testing environment for the "launch jenkins(debug)" command and I think I found the cause of the crashes. You are setting namelist_file = 'INPUT_ORO_ASTER' in src/extpar_consistency_check.f90, but the namelist file should be called just INPUT_ORO.

Let me know if you have problems with this new feature.

Cheers,
Mikael

stelliom · 2025-07-22T12:40:03Z

PS: also, maybe have a look at the new PR template.

stelliom · 2025-10-20T18:00:46Z

Closing as it is not relevant anymore after the update of MERIT/REMA data.

jhelmert added 5 commits May 15, 2025 08:37

Resolve merge conflict

90daa25

Add GLOBE as single option in EXTPAR_TOPO

d2f63c7

Add feature of processing MERIT and GLOBE alone, depending on existin…

062fc1f

…g INPUT_ORO_X

Adapt consistency_check for GLOBE oro

d1f3aad

Adaptions for changes from master

9e09a10

jhelmert force-pushed the merit_scripts branch from 7df1bc3 to 9e09a10 Compare May 15, 2025 11:23

stelliom closed this Oct 20, 2025

Conversation

jonasjucker commented Feb 28, 2025

Uh oh!

jonasjucker commented Feb 28, 2025

Uh oh!

jonasjucker commented Mar 4, 2025

Uh oh!

jonasjucker commented Mar 5, 2025

Uh oh!

jhelmert commented Mar 6, 2025

Uh oh!

jonasjucker commented Mar 19, 2025

Uh oh!

jhelmert commented Mar 19, 2025

Uh oh!

stelliom commented Apr 29, 2025

Uh oh!

jhelmert commented May 6, 2025

Uh oh!

stelliom commented May 9, 2025

Uh oh!

stelliom commented May 9, 2025

Uh oh!

stelliom commented May 12, 2025

Uh oh!

jhelmert commented May 16, 2025

Uh oh!

stelliom commented May 26, 2025

Uh oh!

stelliom commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stelliom commented Jul 22, 2025

Uh oh!

stelliom commented Jul 22, 2025

Uh oh!

stelliom commented Oct 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stelliom commented May 26, 2025 •

edited

Loading