Player Events - Add debug logging & make VisionModeChanged use engine event#1671
Open
LinkIsGrim wants to merge 16 commits intoCBATeam:masterfrom
Open
Player Events - Add debug logging & make VisionModeChanged use engine event#1671LinkIsGrim wants to merge 16 commits intoCBATeam:masterfrom
LinkIsGrim wants to merge 16 commits intoCBATeam:masterfrom
Conversation
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: commy2 <commy-2@gmx.de>
Co-authored-by: commy2 <commy-2@gmx.de>
Co-authored-by: commy2 <commy-2@gmx.de>
Contributor
|
quick tested controlling UAVs and the event seems to work fine vision mode seems to just be whatever you are controlling, e.g. no nvgs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:*
Proof of concept PR, want to see what changes will be necessary for other events (delay for one frame?) and catch any edge cases (one I can think of is player not using NVG and switching to UAV with NVG on, and vice-versa. I'm not sure of the best way to handle that).
Requires #1669 & #1670