Skip to content

[FIX]Fix panic when using --mp4/--mkv without explicit input format #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gaurav02081 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[FIX]Fix panic when using --mp4/--mkv without explicit input format #2107

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3be8ae8
Fix panic when using --mp4/--mkv without explicit input format
gaurav-dev02 Feb 10, 2026
0678d93
Restored Autodetection Logic &Fixed TCP Input Regressio
gaurav-dev02 Feb 11, 2026
5606834
style: apply cargo fmt
gaurav-dev02 Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 22 additions & 16 deletions src/rust/src/parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,11 +285,17 @@ impl OptionsExt for Options {
self.set_input_format_type(InFormat::Asf);
} else if args.wtv {
self.set_input_format_type(InFormat::Wtv);
} else if args.mp4 {
self.set_input_format_type(InFormat::Mp4);
} else if args.mkv {
self.set_input_format_type(InFormat::Mkv);
} else {
fatal!(
cause = ExitCause::MalformedParameter;
"Unknown input file format: {}\n", args.input.unwrap()
);
// fatal!(
// cause = ExitCause::MalformedParameter;
// "Unknown input file format: {}\n", args.input.map(|i| i.to_string()).unwrap_or_else(|| "Unknown".to_string())
// );

// No specific format flag matched, so we fall back to autodetection.
}
}

Expand Down Expand Up @@ -658,18 +664,18 @@ impl OptionsExt for Options {
self.timestamp_map = true;
}

if args.es
|| args.ts
|| args.ps
|| args.asf
|| args.wtv
|| args.mp4
|| args.mkv
|| args.dvr_ms
|| args.input.is_some()
{
self.set_input_format(args);
}
// if args.es
// || args.ts
// || args.ps
// || args.asf
// || args.wtv
// || args.mp4
// || args.mkv
// || args.dvr_ms
// || args.input.is_some()
// {
self.set_input_format(args);
// }

if let Some(ref codec) = args.codec {
match codec {
Expand Down
Loading