feat: make start field editable#190
Conversation
|
Looks okay to me, please fix the conflicts |
|
Hell1213
force-pushed
the
feat/make-start-field-editable
branch
from
a7cb28a to
be70048
Compare
All set now, everything’s fixed and the PR is ready for review and merge whenever you get a time. |
its-me-abhishek
left a comment
its-me-abhishek
left a comment
There was a problem hiding this comment.
Please look into this
|
|
||
| // add task to the user's tw client | ||
| func AddTaskToTaskwarrior(email, encryptionSecret, uuid, description, project, priority, dueDate string, tags []string) error { | ||
| if err := utils.ExecCommand("rm", "-rf", "/root/.task"); err != nil { |
There was a problem hiding this comment.
why's this removed?
| ) | ||
|
|
||
| func CompleteTaskInTaskwarrior(email, encryptionSecret, uuid, taskuuid string) error { | ||
| if err := utils.ExecCommand("rm", "-rf", "/root/.task"); err != nil { |
There was a problem hiding this comment.
why's this removed as well?
| return err | ||
| } | ||
|
|
||
| // Escape the double quotes in the description and format it |
There was a problem hiding this comment.
the older comment provided more context imo
|
|
||
| func TestEditTaskInATaskwarrior(t *testing.T) { | ||
| err := EditTaskInTaskwarrior("uuid", "description", "email", "encryptionSecret", "taskuuid", nil, "project") | ||
| err := EditTaskInTaskwarrior("uuid", "description", "email", "encryptionSecret", "taskuuid", nil, "project", "") |
There was a problem hiding this comment.
passing an empty field makes the test pretty vague
| // sync the user's tasks to all of their TW clients | ||
| func SyncTaskwarrior(tempDir string) error { | ||
| if err := utils.ExecCommandInDir(tempDir, "task", "sync"); err != nil { | ||
| if err := utils.ExecCommandInDir(tempDir, "task", "sync", "rc.confirmation=off"); err != nil { |
There was a problem hiding this comment.
this is not related to the scope of PR though, why'd we edit this?
There was a problem hiding this comment.
You're right, I went beyond scope. Those files were giving me errors during testing so I fixed them too, but should've kept the PR focused on just the start field.
Should I revert the unrelated changes and keep only edit_task.go + frontend files?
|
@its-me-abhishek |
Added start date field editing functionality to tasks
Hell1213
force-pushed
the
feat/make-start-field-editable
branch
from
be70048 to
7704b61
Compare
|
@its-me-abhishek ,plss kindly have a look ,ready for review ! |
| ) | ||
|
|
||
| func EditTaskInTaskwarrior(uuid, description, email, encryptionSecret, taskID string, tags []string, project string) error { | ||
| if err := utils.ExecCommand("rm", "-rf", "/root/.task"); err != nil { |
There was a problem hiding this comment.
this shall be reverted. this file is also using ExecCommandsinDir instead of ExecCommands; which is also not really desired so please fix that
There was a problem hiding this comment.
I'll add back the rm -rf /root/.task lines. For ExecCommandInDir vs ExecCommand - should I use ExecCommand to match main branch, or keep ExecCommandInDir since SetTaskwarriorConfig uses it with tempDir?
There was a problem hiding this comment.
I'd say just ExecCommand will work, as it is currently, in main
There was a problem hiding this comment.
yeah I have pushed with accurate changes , it should be fine now !!
Added start date field editing functionality to tasks
Hell1213
force-pushed
the
feat/make-start-field-editable
branch
from
e774ce0 to
e476e22
Compare
* feat: make start field editable Added start date field editing functionality to tasks * feat: make start field editable Added start date field editing functionality to tasks --------- Co-authored-by: Anirban Biswas <139000437+Rustix69@users.noreply.github.com>
3 participants
Description
Users can now edit the start date field directly from the task details dialog. Click the pencil icon next to the start field, select a date, and save.
While implementing this, I fixed some issues with taskwarrior command execution that were causing failures when adding or modifying tasks. The backend now properly uses temporary directories and the frontend correctly identifies tasks by UUID instead of ID.
What's Working
Changes Made
Frontend:
Backend:
Screenshots:
Video Demo:
Screencast.from.2025-11-16.11-17-46.mp4
Checklist
npx prettier --write .(for formatting)gofmt -w .(for Go backend)npm test(for JS/TS testing)Additional Notes
This PR addresses one item from issue #166. The taskwarrior integration tests fail in local dev environment because they require a real taskwarrior server setup, but the feature works correctly in the actual application.