Add end field to Add Task feature#196
Closed
Eshaan-byte wants to merge 2 commits into
Closed
Conversation
- Add start date field to frontend Add Task dialog (desktop & mobile) - Update newTask state to include start field - Update addTaskToBackend API call with start parameter - Add Start field to backend AddTaskRequestBody model - Update AddTaskHandler to extract and pass start field - Update AddTaskToTaskwarrior to include scheduled date in taskwarrior command - Use 'scheduled' attribute in taskwarrior (maps to start date) - Start field is optional and only added if provided Implements CCExtractor#188 (Start field)
This commit adds support for the 'end' field when creating tasks through the UI. Frontend changes: - Added 'end' field to newTask state - Added End DatePicker input to both Add Task dialogs - Updated handleAddTask function to accept and pass 'end' parameter - Updated addTaskToBackend to send 'end' to the backend API Backend changes: - Added 'End' field to AddTaskRequestBody model - Updated AddTaskHandler to extract and process 'end' field - Updated AddTaskToTaskwarrior function to accept and handle 'end' parameter - Added 'end:' attribute to taskwarrior command when provided
Collaborator
|
This seems to implement Start as Scheduled, while mentioning addition of End field in the Add Task panel, hence is confusing and not relevant. Closing For Now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the end field when creating tasks through the UI, allowing users to specify an end date for their tasks directly from the Add Task dialog.
This is part of the ongoing effort to make more task fields editable through the frontend interface, as outlined in the original issue.
Changes Made
Frontend Changes:
endfield tonewTaskstate in Tasks componenthandleAddTaskfunction to accept and passendparameteraddTaskToBackendAPI function to sendendfield to backendendfield properly when form is clearedBackend Changes:
Endfield toAddTaskRequestBodymodelAddTaskHandlercontroller to extract and processendfieldAddTaskToTaskwarriorfunction signature to acceptendparameterend:attribute to taskwarrior command whenendvalue is provided