Skip to content

refactor add and edit task#244

Closed
Ankit-69k wants to merge 1 commit into
CCExtractor:mainfrom
Ankit-69k:refactor/task
Closed

refactor add and edit task#244
Ankit-69k wants to merge 1 commit into
CCExtractor:mainfrom
Ankit-69k:refactor/task

Conversation

@Ankit-69k
Copy link
Copy Markdown
Contributor

Description

Checklist

  • Ran npx prettier --write . (for formatting)
  • Ran gofmt -w . (for Go backend)

Additional Note

  • created 2 files for edit and create task
  • passing the states from task.tsk to these components

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 5, 2025

Thank you for opening this PR!

Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools.

Please take a moment to:

  • Check the "Files changed" tab
  • Leave comments on any lines for functions, comments, etc. that are important, non-obvious, or may need attention
  • Clarify decisions you made or areas you might be unsure about and/or any future updates being considered.
  • Finally, submit all the comments!

This helps make the review process smoother and gives us a clearer understanding of your thought process.

Once you've added your self-review, we'll continue from our side. Thank you!

@ShivaGupta-14
Copy link
Copy Markdown
Contributor

ShivaGupta-14 commented Dec 5, 2025

Hi @Ankit-69k!

Just wanted to give you a heads-up, the CI pipeline is failing on this PR due to TypeScript compilation errors.

Issue

The file src/components/HomeComponents/Tasks/Tasks.tsx has some unused imports that TypeScript's noUnusedLocals rule is flagging:

  • DialogClose (line 19)
  • CheckIcon, CopyIcon, PencilIcon, Tag, Trash2Icon, XIcon (lines 29-36)
  • Select block from @/components/ui/select (lines 40-46)
  • CopyToClipboard (line 47)
  • formattedDate (line 49)

CI Logs

You can check the full error details here:
GitHub Actions Logs

And you can check all test locally by using npm test

Once the unused import errors are resolved, the CI should pass and the PR will be ready for review!

Let me know if you need any help.

@Ankit-69k
Copy link
Copy Markdown
Contributor Author

Hi @Ankit-69k!

Just wanted to give you a heads-up, the CI pipeline is failing on this PR due to TypeScript compilation errors.

Issue

The file src/components/HomeComponents/Tasks/Tasks.tsx has some unused imports that TypeScript's noUnusedLocals rule is flagging:

  • DialogClose (line 19)
  • CheckIcon, CopyIcon, PencilIcon, Tag, Trash2Icon, XIcon (lines 29-36)
  • Select block from @/components/ui/select (lines 40-46)
  • CopyToClipboard (line 47)
  • formattedDate (line 49)

CI Logs

You can check the full error details here: GitHub Actions Logs

And you can check all test locally by using npm test

Once the unused import errors are resolved, the CI should pass and the PR will be ready for review!

Let me know if you need any help.

yeah i was going to do that but @Neeraj-gagat told me his PR is already ready to merge..... should I resolve the issue or take some other issues?

@Neeraj-gagat
Copy link
Copy Markdown
Contributor

@Ankit-69k take someother issue bro i am fixing this one

@Ankit-69k Ankit-69k closed this Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Break down Tasks.tsx into smaller files and utilities with incremental, tested PRs

3 participants