Hide broken Discord and Email link and update layout classes#288
Closed
jnakaigen wants to merge 1 commit into
Closed
Hide broken Discord and Email link and update layout classes#288jnakaigen wants to merge 1 commit into
jnakaigen wants to merge 1 commit into
Conversation
Temporarily hide broken links for Discord and adjust layout classes.
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
Collaborator
|
This is not really required, closing until we find something else instead! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a layout alignment issue in the "Contact Us" section and temporarily hides incomplete contact options to improve user experience.
Changes made:
contactListarray. These items had empty URL strings (''), which caused the page to reload or jump when clicked.grid lg:grid-cols-4) to a flexible centered layout (flex flex-wrap justify-center). This ensures the remaining two cards (Zulip and Github) are perfectly centered on the screen, rather than being stuck on the left side.Checklist
npx prettier --write .(for formatting)gofmt -w .(for Go backend)npm test(for JS/TS testing)Additional Notes
The switch to
flex-wrapis future-proof; if the Discord and Email links are uncommented later, the layout will automatically adjust to center all 4 items again.Note to Maintainers: I commented out the Discord and Email sections because their URLs were missing. If you have the valid invite links, let me know and I can update the
URLsfile and uncomment these sections.