test(Tasks): Add comprehensive test suite for Tasks component#427
test(Tasks): Add comprehensive test suite for Tasks component#427ShivaGupta-14 wants to merge 1 commit into
Conversation
- Reorganize existing tests into proper describe blocks
- Add tests for Keyboard Navigation (ArrowUp, ArrowDown, boundary stops)
- Add tests for Hotkey Shortcuts ('a', 'c', 'd', 'f', 'p', 'r', 's', 't')
- Add tests for complete/delete hotkeys when dialog is already open
- Add test for hotkeys disabled when input is focused
- Add tests for Hotkeys Enable/Disable on Hover
- Update MultiSelectFilter mock to use aria-expanded for behavior testing
- Remove unnecessary mock override in overdue filter test
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
|
Hey @ShivaGupta-14, thanks for the PR! This one is similar to #356, and similar to earlier discussion, with all the tests and changes it’s a bit heavy to review in one go. Might be better to break it down and open PRs per sub-component smaller diffs will make reviews smoother. About Part 1 of 3 (and upcoming parts), feel free to open up a separate issue or a tracker for these, and breakdown these further as required. EDIT: For ex: Just add |
|
Closing for now |
|
Hi @its-me-abhishek! as you suggested, I have now created a tracker issue #433 and open further smaller PRs for easier review :) |
2 participants
Description
Use test.each to keep similar tests clean, readable, and DRY
Reorganize existing tests into proper describe blocks
Add tests for Keyboard Navigation (ArrowUp, ArrowDown, boundary stops)
Add tests for Hotkey Shortcuts ('a', 'c', 'd', 'f', 'p', 'r', 's', 't')
Add tests for complete/delete hotkeys when dialog is already open
Add test for hotkeys disabled when input is focused
Add tests for Hotkeys Enable/Disable on Hover
Update MultiSelectFilter mock to use aria-expanded for behavior testing
Remove unnecessary mock override in overdue filter test
Contributes: Add frontend test suites/cases for src/components/HomeComponents/Tasks #300
Checklist
npx prettier --write .(for formatting)gofmt -w .(for Go backend)npm test(for JS/TS testing)Additional Notes
Before:
After:
Note
This is Part 1 of 3 for comprehensive Tasks.tsx test coverage.
Will open the remaining PRs after completing review of this pr.