refactor(rust): modularize tc_helper, add typed errors, surface task …

.github/workflows/build-tc-helper.yml

@@ -0,0 +1,72 @@
+# Compiles the tc_helper Rust native library from source (instead of relying on
+# the pre-built .so committed under android/app/src/main/jniLibs/) and then
+# builds the production APK against the freshly-compiled library.
+#
+# This is the "proper" fix for stale committed binaries: the .so is regenerated
+# from rust/ on every run, so it can never drift from the Rust source. Once this
+# is green, the committed jniLibs/*.so can be git-ignored and purged from history.
+#
+# NOTE: This workflow has not yet been run on CI — action versions, the NDK
+# version, and the cargo-ndk invocation are transcribed from a verified LOCAL
+# build (macOS) and may need small adjustments on the first CI run.
+#
+# Both arm64-v8a and armeabi-v7a are built. taskchampion is configured with only
+# the server-sync backend (see rust/Cargo.toml), so there's no aws-lc-sys — hence
+# no cmake/ninja/bindgen/libclang toolchain needed; ring builds with just the
+# Rust + NDK toolchain.
+name: Build tc_helper (compile from source)
+
+on:
+  workflow_dispatch:
+  pull_request:
+    branches: [main, reports]
+    paths:
+      - "rust/**"
+      - "android/**"
+      - ".github/workflows/build-tc-helper.yml"
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: actions/setup-java@v4
+        with:
+          distribution: "temurin"
+          java-version: "17"
+
+      # Android SDK + NDK. cargo-ndk reads ANDROID_NDK_HOME to find the toolchain.
+      - uses: android-actions/setup-android@v3
+      - name: Install NDK
+        run: |
+          sdkmanager "ndk;26.1.10909125"
+          echo "ANDROID_NDK_HOME=$ANDROID_HOME/ndk/26.1.10909125" >> "$GITHUB_ENV"
+
+      - name: Install Rust + Android targets + cargo-ndk
+        run: |
+          rustup toolchain install stable --profile minimal
+          rustup target add aarch64-linux-android armv7-linux-androideabi
+          cargo install cargo-ndk --version ^4
+
+      - name: Compile tc_helper (arm64-v8a + armeabi-v7a) from source
+        working-directory: rust
+        run: |
+          cargo ndk -t arm64-v8a -t armeabi-v7a \
+            -o ../android/app/src/main/jniLibs \
+            build --release
+
+      - name: Show freshly-built libs
+        run: ls -lhR android/app/src/main/jniLibs/
+
+      - uses: subosito/flutter-action@v2
+        with:
+          flutter-version: "3.44.5"
+
+      - run: flutter pub get
+      - run: flutter build apk --release --flavor production
+
+      - uses: actions/upload-artifact@v4
+        with:
+          name: production-apk-from-source
+          path: build/app/outputs/flutter-apk/app-production-release.apk

ios/tc_helper.xcframework/Info.plist

@@ -8,32 +8,32 @@
 			<key>BinaryPath</key>
 			<string>tc_helper.framework/tc_helper</string>
 			<key>LibraryIdentifier</key>
-			<string>ios-arm64</string>
+			<string>ios-arm64_x86_64-simulator</string>
 			<key>LibraryPath</key>
 			<string>tc_helper.framework</string>
 			<key>SupportedArchitectures</key>
 			<array>
 				<string>arm64</string>
+				<string>x86_64</string>
 			</array>
 			<key>SupportedPlatform</key>
 			<string>ios</string>
+			<key>SupportedPlatformVariant</key>
+			<string>simulator</string>
 		</dict>
 		<dict>
 			<key>BinaryPath</key>
 			<string>tc_helper.framework/tc_helper</string>
 			<key>LibraryIdentifier</key>
-			<string>ios-arm64_x86_64-simulator</string>
+			<string>ios-arm64</string>
 			<key>LibraryPath</key>
 			<string>tc_helper.framework</string>
 			<key>SupportedArchitectures</key>
 			<array>
 				<string>arm64</string>
-				<string>x86_64</string>
 			</array>
 			<key>SupportedPlatform</key>
 			<string>ios</string>
-			<key>SupportedPlatformVariant</key>
-			<string>simulator</string>
 		</dict>
 	</array>
 	<key>CFBundlePackageType</key>

lib/app/modules/home/controllers/home_controller.dart

@@ -51,6 +51,11 @@ class HomeController extends GetxController {
   final RxSet<String> selectedTags = <String>{}.obs;
   final RxList<Task> queriedTasks = <Task>[].obs;
   final RxList<Task> searchedTasks = <Task>[].obs;
+  // Reactive mirror of the search box text. `searchedTasks` only drives the
+  // local-taskc list (TasksBuilder); the TaskChampion replica list reads
+  // `tasksFromReplica` directly, so it needs an observable query to rebuild and
+  // filter on each keystroke. Kept in sync by search()/toggleSearch().
+  final RxString searchQuery = ''.obs;
   final RxList<DateTime?> selectedDates = List<DateTime?>.filled(4, null).obs;
   final RxMap<String, TagMetadata> pendingTags = <String, TagMetadata>{}.obs;
   final RxMap<String, ProjectNode> projects = <String, ProjectNode>{}.obs;
@@ -86,6 +91,12 @@ class HomeController extends GetxController {
     taskdb = TaskDatabase();
     taskdb.open();
     getUniqueProjects();
+    // Initialize the pending/waiting filters from their persisted values.
+    // Without this the RxBool defaults to false, and the replica list view
+    // (which filters `status == pending` only when pendingFilter is true)
+    // shows completed tasks only — hiding every pending task on first load.
+    pendingFilter.value = Query(storage.tabs.tab()).getPendingFilter();
+    waitingFilter.value = Query(storage.tabs.tab()).getWaitingFilter();
     _loadTaskChampion();
     fetchTasksFromDB();
 
@@ -499,10 +510,12 @@ class HomeController extends GetxController {
     if (!searchVisible.value) {
       searchedTasks.assignAll(queriedTasks);
       searchController.text = '';
+      searchQuery.value = '';
     }
   }
 
   void search(String term) {
+    searchQuery.value = term;
     searchedTasks.assignAll(
       queriedTasks
           .where(

lib/app/modules/home/views/home_page_body.dart

@@ -30,7 +30,25 @@ class HomePageBody extends StatelessWidget {
         child: Padding(
           padding: const EdgeInsets.only(left: 8.0, right: 8.0),
           child: Obx(
-            () => Column(
+            () {
+              // Read the replica list reactively here so the whole view rebuilds
+              // when tasks arrive. On launch, taskReplica flips true (triggering a
+              // rebuild) *before* the async FFI fetch populates tasksFromReplica;
+              // without a reactive read of the list itself, the populated tasks
+              // would never appear (the view stays on its initial empty build).
+              var replicaTasks = controller.tasksFromReplica.toList();
+              // Apply the search text to the replica list. Unlike the local-taskc
+              // path (which reads the pre-filtered `searchedTasks`), this builder
+              // gets the raw list, so filter here. Reading `searchQuery`/
+              // `searchVisible` inside the Obx makes it rebuild on each keystroke.
+              final query = controller.searchQuery.value.trim().toLowerCase();
+              if (controller.searchVisible.value && query.isNotEmpty) {
+                replicaTasks = replicaTasks
+                    .where((task) =>
+                        (task.description ?? '').toLowerCase().contains(query))
+                    .toList();
+              }
+              return Column(
               children: <Widget>[
                 if (controller.searchVisible.value)
                   Container(
@@ -134,14 +152,15 @@ class HomePageBody extends StatelessWidget {
                     child: Expanded(
                         child: Scrollbar(
                       child: TaskReplicaViewBuilder(
-                        replicaTasks: controller.tasksFromReplica,
+                        replicaTasks: replicaTasks,
                         pendingFilter: controller.pendingFilter.value,
                         selectedSort: controller.selectedSort.value,
                         project: controller.projectFilter.value,
                       ),
                     )))
               ],
-            ),
+              );
+            },
           ),
         ),
       ),

lib/app/modules/home/views/show_tasks_replica.dart

@@ -31,9 +31,11 @@ class TaskReplicaViewBuilder extends StatelessWidget {
     TaskwarriorColorTheme tColors =
         Theme.of(context).extension<TaskwarriorColorTheme>()!;
 
-    return Obx(() {
-      List<TaskForReplica> tasks = List<TaskForReplica>.from(replicaTasks);
-      if (project != null && project != 'All Projects') {
+    // Reactivity is handled by the parent Obx in home_page_body (which reads
+    // tasksFromReplica); this widget just renders the snapshot it's given, so
+    // it must NOT be an Obx (an Obx with no observable read throws ObxError).
+    List<TaskForReplica> tasks = List<TaskForReplica>.from(replicaTasks);
+      if (project != null && project!.isNotEmpty && project != 'All Projects') {
         tasks = tasks.where((task) => task.project == project).toList();
       }
       tasks.sort((a, b) {
@@ -203,7 +205,6 @@ class TaskReplicaViewBuilder extends StatelessWidget {
                 },
               ),
       );
-    });
   }
 
   Color _getPriorityColor(String priority) {

lib/app/modules/manageTaskServer/controllers/manage_task_server_controller.dart

@@ -9,6 +9,7 @@ import 'package:taskwarrior/app/models/storage/set_config.dart';
 import 'package:taskwarrior/app/modules/home/controllers/home_controller.dart';
 import 'package:taskwarrior/app/modules/splash/controllers/splash_controller.dart';
 import 'package:taskwarrior/app/tour/manage_task_server_page_tour.dart';
+import 'package:taskwarrior/app/tour/safe_tour.dart';
 import 'package:taskwarrior/app/utils/constants/taskwarrior_colors.dart';
 import 'package:taskwarrior/app/utils/home_path/home_path.dart' as rc;
 import 'package:taskwarrior/app/utils/taskserver/taskserver.dart';
@@ -221,18 +222,20 @@ class ManageTaskServerController extends GetxController {
   void showManageTaskServerPageTour(BuildContext context) {
     Future.delayed(
       const Duration(milliseconds: 500),
-      () {
-        SaveTourStatus.getManageTaskServerTourStatus().then((value) => {
-              if (value == false)
-                {
-                  tutorialCoachMark.show(context: context),
-                }
-              else
-                {
-                  // ignore: avoid_print
-                  print('User has seen this page'),
-                }
-            });
+      () async {
+        final seen = await SaveTourStatus.getManageTaskServerTourStatus();
+        if (seen) return;
+        await safeShowTour(
+          tutorialCoachMark: tutorialCoachMark,
+          context: context,
+          targetKeys: [
+            configureTaskRC,
+            configureServerCertificate,
+            configureTaskServerKey,
+            configureYourCertificate,
+          ],
+          markSeen: () => SaveTourStatus.saveManageTaskServerTourStatus(true),
+        );
       },
     );
   }

lib/app/modules/profile/controllers/profile_controller.dart

@@ -2,6 +2,7 @@ import 'package:flutter/material.dart';
 import 'package:get/get.dart';
 import 'package:taskwarrior/app/modules/splash/controllers/splash_controller.dart';
 import 'package:taskwarrior/app/tour/profile_page_tour.dart';
+import 'package:taskwarrior/app/tour/safe_tour.dart';
 import 'package:taskwarrior/app/utils/constants/taskwarrior_colors.dart';
 import 'package:taskwarrior/app/utils/app_settings/app_settings.dart';
 import 'package:tutorial_coach_mark/tutorial_coach_mark.dart';
@@ -45,18 +46,19 @@ class ProfileController extends GetxController {
   void showProfilePageTour(BuildContext context) {
     Future.delayed(
       const Duration(milliseconds: 500),
-      () {
-        SaveTourStatus.getProfileTourStatus().then((value) => {
-              if (value == false)
-                {
-                  tutorialCoachMark.show(context: context),
-                }
-              else
-                {
-                  // ignore: avoid_print
-                  print('User has seen this page'),
-                }
-            });
+      () async {
+        final seen = await SaveTourStatus.getProfileTourStatus();
+        if (seen) return;
+        await safeShowTour(
+          tutorialCoachMark: tutorialCoachMark,
+          context: context,
+          targetKeys: [
+            currentProfileKey,
+            addNewProfileKey,
+            manageSelectedProfileKey,
+          ],
+          markSeen: () => SaveTourStatus.saveProfileTourStatus(true),
+        );
       },
     );
   }

lib/app/modules/taskc_details/controllers/taskc_details_controller.dart

@@ -35,6 +35,9 @@ class TaskcDetailsController extends GetxController {
   late RxString rtype;
   late RxString recur;
   late RxList<Annotation> annotations;
+  // Blocking state surfaced by the Rust serializer (replica tasks only).
+  late RxBool isBlocked;
+  late RxBool isBlocking;
   late RxList<String> previousTags = <String>[].obs;
 
   @override
@@ -64,6 +67,8 @@ class TaskcDetailsController extends GetxController {
       rtype = "".obs;
       recur = "".obs;
       annotations = <Annotation>[].obs;
+      isBlocked = false.obs;
+      isBlocking = false.obs;
     } else if (task is TaskForReplica) {
       description = (task.description ?? '').obs;
       project = (task.project ?? 'None').obs;
@@ -81,10 +86,13 @@ class TaskcDetailsController extends GetxController {
           ? task.tags!.map((e) => e.toString()).toList().obs
           : <String>[].obs;
       previousTags = tags.toList().obs;
-      depends = "".split(",").obs;
+      // Attributes now surfaced by the Rust serializer.
+      depends = (task.depends ?? <String>[]).obs;
       rtype = "".obs;
-      recur = "".obs;
-      annotations = <Annotation>[].obs;
+      recur = (task.recur ?? "").obs;
+      annotations = (task.annotations ?? <Annotation>[]).obs;
+      isBlocked = (task.isBlocked ?? false).obs;
+      isBlocking = (task.isBlocking ?? false).obs;
     } else {
       // Fallback
       description = ''.obs;
@@ -100,6 +108,8 @@ class TaskcDetailsController extends GetxController {
       rtype = "".obs;
       recur = "".obs;
       annotations = <Annotation>[].obs;
+      isBlocked = false.obs;
+      isBlocking = false.obs;
     }
   }
 

lib/app/modules/taskc_details/views/taskc_details_view.dart

@@ -111,6 +111,45 @@ class TaskcDetailsView extends GetView<TaskcDetailsController> {
                   controller.tags.join(', '),
                   (value) => controller.updateListField(controller.tags, value),
                 ),
+                // Attributes surfaced by the enriched Rust serializer (D2).
+                // Replica tasks only; read-only (the mobile UI cannot edit
+                // dependencies/annotations yet).
+                if (controller.isReplicaTask) ...[
+                  _buildDetail(
+                    context,
+                    'Blocked:',
+                    controller.isBlocked.value ? 'Yes' : 'No',
+                  ),
+                  _buildDetail(
+                    context,
+                    'Blocking:',
+                    controller.isBlocking.value ? 'Yes' : 'No',
+                  ),
+                  _buildDetail(
+                    context,
+                    'Depends:',
+                    controller.depends.isEmpty
+                        ? 'None'
+                        : controller.depends.join(', '),
+                  ),
+                  _buildDetail(
+                    context,
+                    'Recur:',
+                    controller.recur.value.isEmpty
+                        ? 'None'
+                        : controller.recur.value,
+                  ),
+                  _buildDetail(
+                    context,
+                    'Annotations:',
+                    controller.annotations.isEmpty
+                        ? 'None'
+                        : controller.annotations
+                            .map((a) =>
+                                '• ${a.description ?? ''}${(a.entry != null && a.entry!.isNotEmpty) ? '  (${a.entry})' : ''}')
+                            .join('\n'),
+                  ),
+                ],
                 if (controller.isLocalTask) ...[
                   _buildDetail(
                     context,