fix: isolate lexer defaults per instance#2
Open
codefix-patchflow[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
Creating a
new marked.Lexer()and then calling the staticmarked.Lexer.lex()could make the original lexer instance return paragraph tokens with empty inlinetokens.The default lexer constructor was writing a newly-created tokenizer back onto the shared
_defaultsoptions object. Later lexer construction reused and repointed that tokenizer'slexerreference, so an older lexer instance could enqueue inline tokens on the wrong lexer.What changed
The lexer constructor now creates a shallow per-instance options object from
defaultsplus the provided options before assigning a fallback tokenizerWhy this works
When no explicit tokenizer is supplied, each lexer instance receives its own tokenizer through its own options object instead of mutating
defaults.tokenizer. Static and instance lexing no longer share a tokenizer whoselexerpointer can be overwritten by later constructionExpected result
marked.Lexer.lex("Test")andnew marked.Lexer().lex("Test")should produce identical token arrays, including populated inline paragraph tokensPatchflow did not run repository-local commands; the automated review gate checks the patch without assuming the project full runtime environment is available.
🔧 Fixed automatically by Patchflow — $1/fix · no fix, no fee
Automation details