Skip to content

fix: handle require edge case #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codefix-patchflow wants to merge 1 commit into
base: patchflow-red-qs-493
Choose a base branch
from
Open

fix: handle require edge case #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 35 additions & 10 deletions lib/parse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,26 @@ var parseObject = function (chain, val, options, valuesParsed) {
return leaf;
};

var findClosingBracket = function (key, start) {
var depth = 0;

for (var i = start; i < key.length; ++i) {
var char = key.charAt(i);

if (char === '[') {
depth += 1;
} else if (char === ']') {
depth -= 1;

if (depth === 0) {
return i;
}
}
}

return -1;
};

var splitKeyIntoSegments = function splitKeyIntoSegments(givenKey, options) {
var key = options.allowDots ? givenKey.replace(/\.([^.[]+)/g, '[$1]') : givenKey;

Expand All @@ -227,11 +247,8 @@ var splitKeyIntoSegments = function splitKeyIntoSegments(givenKey, options) {
return [key];
}

var brackets = /(\[[^[\]]*])/;
var child = /(\[[^[\]]*])/g;

var segment = brackets.exec(key);
var parent = segment ? key.slice(0, segment.index) : key;
var segmentStart = key.indexOf('[');
var parent = segmentStart > -1 ? key.slice(0, segmentStart) : key;

var keys = [];

Expand All @@ -246,25 +263,33 @@ var splitKeyIntoSegments = function splitKeyIntoSegments(givenKey, options) {
}

var i = 0;
while ((segment = child.exec(key)) !== null && i < options.depth) {
while (segmentStart > -1 && i < options.depth) {
var segmentEnd = findClosingBracket(key, segmentStart);

if (segmentEnd === -1) {
break;
}

i += 1;

var segmentContent = segment[1].slice(1, -1);
var segment = key.slice(segmentStart, segmentEnd + 1);
var segmentContent = segment.slice(1, -1);
if (!options.plainObjects && has.call(Object.prototype, segmentContent)) {
if (!options.allowPrototypes) {
return;
}
}

keys[keys.length] = segment[1];
keys[keys.length] = segment;
segmentStart = key.indexOf('[', segmentEnd + 1);
}

if (segment) {
if (segmentStart > -1) {
if (options.strictDepth === true) {
throw new RangeError('Input depth exceeded depth option of ' + options.depth + ' and strictDepth is true');
}

keys[keys.length] = '[' + key.slice(segment.index) + ']';
keys[keys.length] = '[' + key.slice(segmentStart) + ']';
}

return keys;
Expand Down
Loading