fix: treat protocol-less host:port URLs as valid in isURL#1
Open
codefix-patchflow[bot] wants to merge 1 commit into
Open
fix: treat protocol-less host:port URLs as valid in isURL#1codefix-patchflow[bot] wants to merge 1 commit into
codefix-patchflow[bot] wants to merge 1 commit into
Conversation
9b4a9e2 to
a3932e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
isURLtreated protocol-less service URLs such asmy-3272-service:9000as ifmy-3272-servicewere a protocol, so validation returnedfalseafter the 13.15.20 update even withrequire_tld: falseandrequire_valid_protocol: false.What changed
src/lib/isURL.jsnow detects a numerichost:portsuffix before consuming text before:as a protocol.test/validators.test.jsadds the reportedmy-3272-service:9000regression case.Why this works
The parser distinguishes a numeric host:port suffix from a protocol delimiter, so protocol-less service hostnames continue through normal host and port validation while
require_protocolstill rejects URLs without an explicit protocol.Expected result
validator.isURL("my-3272-service:9000", { require_tld: false, require_valid_protocol: false })returnstrue, and the existing URL validation matrix remains green.Patchflow did not run repository-local commands during generation; GitHub Actions ran the repository CI on the delivered pull request.
🔧 Fixed automatically by Patchflow — $1/fix · no fix, no fee
Automation details