fix: treat protocol-less host:port URLs as valid in isURL#2
Open
codefix-patchflow[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
URL returns false for urls like some-hostname:9000 after 13.15.20 version bump, 13.15.15 works as expected returning true Examples validator.isURL("my-3272-service:9000", { require_tld: false, require_valid_protocol: false }); // returns false in 13.15.20 Additional context Validator.js version: 13.15.20 Node.js version: 22.14.0 OS platform: linux
What changed
Patchflow applied a minimal source change for the reported failure.
Why this works
The parser distinguishes a numeric host:port suffix from a protocol delimiter, so protocol-less service hostnames continue through normal host and port validation while require_protocol still rejects URLs without an explicit protocol.
Expected result
A concise pull request is created with a clear review note
Patchflow did not run repository-local commands; the automated review gate checks the patch without assuming the project full runtime environment is available.
🔧 Fixed automatically by Patchflow — $1/fix · no fix, no fee
Automation details