fix: allow hostname ports without protocol#4
Open
codefix-patchflow[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
isURLtreated values likemy-3272-service:9000as an explicit protocol because the protocol-detection regex consumed the leadingmy-3272-service:token before host and port parsing could run.What changed
Added a host-with-port disambiguation check for protocol-like prefixes without
//or auth data. When the prefix is a valid host and the suffix is a valid numeric port,isURLnow leaves the string intact for the existing hostname and port parser Added the reportedmy-3272-service:9000regression case to the no-protocol URL testsWhy this works
The new check only applies when a protocol is not required, the text after the colon is a valid port, and the text before the colon is accepted as an IP, FQDN, or whitelisted host. Non-numeric scheme bodies such as
custom:somethingand malicious protocol payloads continue through the explicit protocol pathExpected result
validator.isURL("my-3272-service:9000", { requiretld: false, requirevalidprotocol: false })returnstruePatchflow did not run repository-local commands; the automated review gate checks the patch without assuming the project full runtime environment is available.
🔧 Fixed automatically by Patchflow — $1/fix · no fix, no fee
Automation details