fix: preserve no-protocol host:port URL parsing#5
Open
codefix-patchflow[bot] wants to merge 1 commit into
Open
fix: preserve no-protocol host:port URL parsing#5codefix-patchflow[bot] wants to merge 1 commit into
codefix-patchflow[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
isURLtreated a leadinghostname:segment as a protocol whenever it matched the scheme regex. For values likemy-3272-service:9000, that stripped the hostname and left9000to be validated as the host, causing validation to returnfalse.What changed
Left
host:digitsinputs intact for normal host/port parsing whenrequireprotocolisfalseKept existing protocol handling for required-protocol URLs, explicit//protocols, authentication-like inputs, and non-port protocol payloads Added the reportedmy-3272-service:9000case to the no-protocol URL regression testsWhy this works
When the text after the first colon is a numeric port and no protocol is required, the URL should be parsed as
host:portrather than asprotocol:path. The later port validator already enforces numeric port range rules, so this restores the expected path without bypassing existing host validationExpected result
validator.isURL("my-3272-service:9000", { requiretld: false, requirevalidprotocol: false })returnstruePatchflow did not run repository-local commands; the automated review gate checks the patch without assuming the project full runtime environment is available.
🔧 Fixed automatically by Patchflow — $1/fix · no fix, no fee
Automation details