fix: recognize ports on protocol-less hostnames#6
Open
codefix-patchflow[bot] wants to merge 1 commit into
Open
fix: recognize ports on protocol-less hostnames#6codefix-patchflow[bot] wants to merge 1 commit into
codefix-patchflow[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
isURLinterpreted the hostname portion ofmy-3272-service:9000as a URL protocol after the 13.15.20 protocol parsing change.With
require_tld: falseandrequire_valid_protocol: false, the hostname was removed as if it were a scheme and validation returnedfalseinstead oftrue.What changed
Treat a numeric component after the first colon as a port when the URL has no
//protocol delimiter Continue rejecting that form whenrequireprotocolis enabled Add the reportedmy-3272-service:9000input to the protocol-less URL regression casesWhy this works
The parser now leaves
hostname:portintact for the existing host and port validation stages. Explicit protocols, non-numeric scheme components, authentication parsing, and port range validation retain their existing pathsExpected result
validator.isURL('my-3272-service:9000', { requiretld: false, requirevalidprotocol: false })returnstruePatchflow did not run repository-local commands; the automated review gate checks the patch without assuming the project full runtime environment is available.
🔧 Fixed automatically by Patchflow — $1/fix · no fix, no fee
Automation details