fix: preserve protocol-less hostnames with ports in isURL#7
Open
codefix-patchflow[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
The scheme regex treated
my-3272-service:as a protocol and removed it, so9000was validated as the hostname and the URL returnedfalse.What changed
Protocol detection now leaves
hostname:numeric-portinputs on the existing host and port parsing path. The reported input was added to the protocol-less URL regression casesWhy this works
Numeric text after the first colon is parsed as a port, while explicit protocols and nonnumeric schemes continue through the existing protocol validation, including its security checks
Expected result
validator.isURL('my-3272-service:9000', { requiretld: false, requirevalidprotocol: false })returnstruePatchflow did not run repository-local commands; the automated review gate checks the patch without assuming the project full runtime environment is available.
🔧 Fixed automatically by Patchflow — $1/fix · no fix, no fee
Automation details