Open
Conversation
…so keeping track of how many boundary surfaces there are
…utoff and boolian operators
…rant xsec lookups
…utations, visualization improvemtns including a movie maker and legend
…rting for delta tracking
Member
|
Thanks, @jpmorgan98. Note that in k-eigenvalue, we can use the collision estimator to get the estimate of the next iterate of k. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a bunch of new tracking features to explore various kinds of hybrid delta tracking schemes. Most of the meat and potatoes is in main.prepare where the majorant is computed and
kernel.move_to_eventwhere delta tracking actually happens.Note that I am adding a
boolto each particle to keep track of weather or not it is undergoing delta tracking. This feels like kinda a big dealNew Features
.gifsand print legendsSome Todos
kernel.move_to_event a little more streamlinedcompute_majorantfunctionality to plot the majorant without having to run the simulationVerification
Passing verification sueit, also producing the correct results with C5G7, C5CE, Kobyashi, and Dragon all of which see speedups when delta tracking is enabled. Or hybrid delta tracking.
New dependency
I am adding a new dependency so that the visualizer can make the movie. Its based on matplotlib and is pretty light weight.
Limitations
This delta tracking does not support fission tallies so also is not supported in k-eigenvalue computations