Continious energy generator bugfixing#359
Open
jpmorgan98 wants to merge 14 commits intoCEMeNT-PSAAP:devfrom
Open
Continious energy generator bugfixing#359jpmorgan98 wants to merge 14 commits intoCEMeNT-PSAAP:devfrom
jpmorgan98 wants to merge 14 commits intoCEMeNT-PSAAP:devfrom
Conversation
Member
|
Thanks, @jpmorgan98 . I see that the PR passed all checks at one point, and then it failed after the next push. Is it still a work in progress? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some issues with the continuous energy generation tooling and adds more robust error handling when things go awry. Adds support for all ACE file interpolation rules and energy sampling techniques including
ACEtk.continuous.MultiDistributionDataas a results runs pretty slow.This may need to be accelerated in the future (multiprocessing)