Open
Conversation
reverting unwanted changes to the .py file
northroj
force-pushed
the
feature/northroj/icsbep
branch
from
1ecdfc0 to
d2c5cc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to the xml translator for use with the ICSBEP problems
When I was making this, I used the xml_translator.py content since it appeared to be a later version than the Translators.ipynb file, but put it in an interactive notebook. To merge it back in, I placed my changes into the Translators.ipynb file instead of the .py file. This unfortunately means that the git diff becomes very messy.
Most changes involve minor tweaks to accept variations in OpenMC's input such as comment blocks in the XML tree and extra whitespace in lists of numbers.
There is a line which specifically excludes U234, U236, Th232, and Pu241 from the MC/DC inputs if they are present in the OpenMC inputs.
This line exists in the geometry section:
Written_Universes = Write_Universes(Geom_Root, py_file)(search "FIX" in the file to find the comment outlining it.) It had to be commented out because it broke all the ICSBEP problems (most of them) if they didn't have universes. I have it commented out, but I think it would need to be added back in to make problems WITH universes work again.