Fix for prompting div location failure#1056
Conversation
sei-vsarvepalli
requested review from
ahouseholder,
cgyarbrough and
j---
as code owners
There was a problem hiding this comment.
Pull request overview
This pull request addresses issue #1055 by fixing a DIV misplacement bug in the SSVC Explorer and exposing the decision_points variable through the SSVC module's public API.
Key changes:
- Corrects HTML structure by repositioning a closing
</div>tag to properly close thessvcPopupcontainer - Adds
decision_pointsto the SSVC module's exported interface for external access
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/ssvc-explorer/index.md | Moves closing </div> tag from line 78 to line 84, fixing the HTML structure of the popup container |
| docs/ssvc-explorer/simple.js | Adds decision_points to the module's return object to expose it in the SSVC API |
| return { | ||
| ssvc_launch: ssvc_launch, | ||
| decision_trees: decision_trees, | ||
| decision_points, decision_points, |
There was a problem hiding this comment.
The syntax for this object property is incorrect. JavaScript object properties should use a colon to separate the key from the value, not a comma. This should be decision_points: decision_points, to properly export the decision_points variable.
| decision_points, decision_points, | |
| decision_points: decision_points, |
There was a problem hiding this comment.
@copilot please make this fix and submit a new PR
| return { | ||
| ssvc_launch: ssvc_launch, | ||
| decision_trees: decision_trees, | ||
| decision_points, decision_points, |
There was a problem hiding this comment.
This property is duplicated in a later property.
| decision_points, decision_points, | |
| decision_points, |
2 participants
Bug fix for #1055 - I think this fixes the issue. It is a simple DIV misplacement problem that caused this. An update to include SSVC.decision_points as an anchor to collect DP's currently created is also added. This pull request contains minor updates to the SSVC Explorer documentation and JavaScript code. The changes include a small fix to the HTML structure and an update to the returned object in the JavaScript module.
Documentation/HTML structure:
</div>tag inindex.mdto ensure proper HTML nesting and rendering.JavaScript module export:
decision_pointsto the returned object of the main function insimple.js, making this property accessible externally.