test: CI comment trigger verification - #15
Draft
harryzhou2000 wants to merge 1 commit into
Draft
Conversation
Collaborator
Author
|
/ci-run-self-hosted |
harryzhou2000
added a commit
to harryzhou2000/DNDSR
that referenced
this pull request
May 21, 2026
… if constexpr, T_guess, rename, Prim2Cons CFDLAB-THU#14: remove static int cnt debug counter from temperature() fallback; replace fprintf with DNDS_assert CFDLAB-THU#15: add DNDS_assert(I.sol/solT != nullptr) in clone() CFDLAB-THU#16: add TODO(#audit MED16) to determine if JAC_SKIP_FLUID removable CFDLAB-THU#17: if(model==NS_2EQ) -> if constexpr (model is template parameter) CFDLAB-THU#18: fallback T_guess 0 -> 200 K (bottom guard for non-reactive mixtures) CFDLAB-THU#19: mixtureFormationEnergy renamed mixtureFormationEnthalpy (returns sum Y_k*h_f_k = formation enthalpy per mass) CFDLAB-THU#20: MeanValuePrim2Cons computes rhoH_form from species densities and passes it to Prim2Cons. 2-pass explanation in comments: pass 1 gets exact rhoH_form (depends only on rho+rhoY_k, which are correct from primitive); pass 2 uses correct gamma+formation making it exact inverse of MeanValueCons2Prim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/ci-runcomment-based trigger works correctly