Refactor meshgen and CleanPSLG for Improved Breakline Processing and Mesh Quality#325
Open
krober10nd wants to merge 10 commits intoProjectionfrom
Open
Refactor meshgen and CleanPSLG for Improved Breakline Processing and Mesh Quality#325krober10nd wants to merge 10 commits intoProjectionfrom
krober10nd wants to merge 10 commits intoProjectionfrom
Conversation
…acting breakline constraint generation into its own method and integrating CleanPSLG processing for high-fidelity mode #3, simplifying breaklines to produce higher geometric quality elements.
… ensuring closed polygons are retained while discarding unclosed line strings
…aN separation and indexing
krober10nd
commented
Mar 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the mesh generation code to enhance modularity and clarity by extracting breakline constraint generation into a dedicated private method. In high-fidelity mode, the integration of the CleanPSLG class simplifies breaklines—merging vertices, removing intersecting edges, and pruning encroaching edges—to produce higher geometric quality elements.