feat: standardize package configuration and workflows

[Zaiidmo]

Standardization Pull Request

Changes

• ✅ Source template for standardized GitHub workflows
• ✅ All checks passing: format, lint, typecheck, build

Status

• ✅ Format: Passing
• ✅ Lint: Passing
• ✅ Typecheck: Passing
• ✅ Build: Passing

All 7 packages now have identical standardized configuration and workflows.

[Copilot]

Pull request overview

This PR updates the @ciscode/notification-kit package setup and introduces/expands the NestJS integration + infrastructure implementations (senders, repositories, providers), along with accompanying documentation and Copilot guidance.

Changes:

• Standardizes build/TS configuration (tsup externals, tsconfig libs + decorators metadata).
• Adds a NestJS dynamic module (register / registerAsync) with DI tokens, decorators, and REST/webhook controllers.
• Adds infra adapters (email/SMS/push senders, repositories, template/id/datetime/event providers) and documents optional peer-dependency usage.

Reviewed changes

Copilot reviewed 31 out of 33 changed files in this pull request and generated 14 comments.

Show a summary per file

File	Description
tsup.config.ts	Marks NestJS + optional SDKs as external for bundling consistency.
tsconfig.json	Adds DOM + decorator metadata settings for NestJS and fetch typing.
src/nest/providers.ts	Introduces provider factory wiring for NotificationKit DI tokens.
src/nest/module.ts	Implements NotificationKitModule.register() / registerAsync().
src/nest/interfaces.ts	Defines module option interfaces (sync + async).
src/nest/index.ts	Re-exports Nest integration surface (module/interfaces/constants/etc.).
src/nest/decorators.ts	Adds helper decorators for injecting NotificationKit tokens.
src/nest/controllers/webhook.controller.ts	Adds inbound webhook controller for delivery callbacks.
src/nest/controllers/notification.controller.ts	Adds REST controller for send/query/retry/cancel operations.
src/nest/constants.ts	Defines DI tokens for module providers.
src/infra/senders/sms/vonage.sender.ts	Adds Vonage SMS sender adapter (lazy SDK import).
src/infra/senders/sms/twilio.sender.ts	Adds Twilio SMS sender adapter (lazy SDK import).
src/infra/senders/sms/aws-sns.sender.ts	Adds AWS SNS SMS sender adapter (lazy SDK import).
src/infra/senders/push/onesignal.sender.ts	Adds OneSignal push sender using fetch.
src/infra/senders/push/firebase.sender.ts	Adds Firebase FCM push sender (lazy SDK import).
src/infra/senders/push/aws-sns-push.sender.ts	Adds AWS SNS push sender adapter (lazy SDK import).
src/infra/senders/index.ts	Aggregates infra sender exports.
src/infra/senders/email/nodemailer.sender.ts	Adds Nodemailer SMTP sender adapter (lazy SDK import).
src/infra/repositories/mongoose/notification.schema.ts	Adds Mongoose schema definition helper.
src/infra/repositories/mongoose/mongoose.repository.ts	Adds Mongoose repository implementation.
src/infra/repositories/index.ts	Aggregates infra repository exports.
src/infra/repositories/in-memory/in-memory.repository.ts	Adds in-memory repository implementation.
src/infra/providers/template.provider.ts	Adds Handlebars + simple template engines.
src/infra/providers/index.ts	Aggregates infra provider exports.
src/infra/providers/id-generator.provider.ts	Adds UUID/ObjectId/NanoId generator implementations.
src/infra/providers/event-emitter.provider.ts	Adds in-memory + console event emitters.
src/infra/providers/datetime.provider.ts	Adds DateTime provider implementation.
src/infra/index.ts	Aggregates infra exports and documents infra layer intent.
src/infra/README.md	Documents infra adapters and installation guidance.
src/index.ts	Exposes core + infra + nest from the package root entrypoint.
package.json	Adds optional peer dependency metadata for provider SDKs.
package-lock.json	Mirrors peerDependenciesMeta changes for lockfile consistency.
.github/copilot-instructions.md	Updates Copilot guidance to be package-specific and more detailed.

[Copilot]

UuidGenerator implements a UUID-like value using Math.random(), which is not suitable for generating unpredictable IDs (and does not guarantee RFC 4122 compliance). Since this is used as the default ID generator, prefer crypto.randomUUID() (Node 20+) or a cryptographically strong generator to avoid collisions/guessable IDs.

Suggested change

	/**
	* ID generator using UUID v4
	*/
	export class UuidGenerator implements IIdGenerator {
	generate(): string {
	// Simple UUID v4 implementation
	return "xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx".replace(/[xy]/g, (c) => {
	const r = (Math.random() * 16) | 0;
	const v = c === "x" ? r : (r & 0x3) | 0x8;
	return v.toString(16);
	});
	import { randomBytes, randomUUID } from "crypto";
	/**
	* ID generator using UUID v4
	*/
	export class UuidGenerator implements IIdGenerator {
	generate(): string {
	// Prefer native crypto.randomUUID when available
	if (typeof randomUUID === "function") {
	return randomUUID();
	}
	// Fallback: generate RFC 4122 v4 UUID from cryptographically secure random bytes
	const bytes = randomBytes(16);
	// Per RFC 4122: set version (4) and variant (RFC 4122)
	bytes[6] = (bytes[6] & 0x0f) | 0x40; // version 4
	bytes[8] = (bytes[8] & 0x3f) | 0x80; // variant 10xxxxxx
	const hex = bytes.toString("hex");
	return (
	hex.slice(0, 8) +
	"-" +
	hex.slice(8, 12) +
	"-" +
	hex.slice(12, 16) +
	"-" +
	hex.slice(16, 20) +
	"-" +
	hex.slice(20)
	);

[Copilot]

The PR description focuses on standardizing configuration/workflows, but this diff introduces substantial new runtime functionality (Nest module registration, controllers, repositories, sender implementations, infra exports). If this is intentional, the PR title/description should be updated to reflect the feature scope; otherwise these additions may be unintended for a “standardization” PR.

[Copilot]

The controller is declared as @Controller() (no path), but the method docs and option name apiPrefix imply routes like /notifications/.... As written, routes will be /send, /bulk-send, /:id, etc., and this.prefix is unused, so the public REST API paths are incorrect/misleading.

[sonarqubecloud]

Quality Gate failed

Failed conditions
5 Security Hotspots
6.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud