Allow slicing FlatSkyMap objects along one dimension#225
Merged
Conversation
Slicing into a FlatSkyMap object along both dimensions returns a new map object with the same coordinate system. This PR also enables slicing along only one of the two dimensions, in which case the returned map object has length 1 along one the other dimension. This behavior previously raised an error.
tcrawfor
approved these changes
Jul 13, 2026
tcrawfor
left a comment
tcrawfor
left a comment
Contributor
There was a problem hiding this comment.
Seems to work as advertised, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slicing into a FlatSkyMap object along both dimensions returns a new map object with the same coordinate system. This PR also enables slicing along only one of the two dimensions, in which case the returned map object has length 1 along the other dimension. This behavior previously raised an error.