Conversation
arahlin
changed the title
arahlin
requested changes
Jun 30, 2026
| } | ||
|
|
||
| std::vector<int> | ||
| FlatSkyMap::BoundingBox(double pad) const |
Member
There was a problem hiding this comment.
Perhaps also pad should be in pixels instead of angular units? That seems more intuitive to me.
arahlin
requested changes
Jun 30, 2026
ssize_t to front of line Co-authored-by: Alexandra Rahlin <arahlin@users.noreply.github.com>
Co-authored-by: Alexandra Rahlin <arahlin@users.noreply.github.com>
* bounding_box method should return a python tuple of integers, because size_t vectors aren't handled well as return values. * crop_to(map) method to crop a map to the same shape as another one * option copy_data=False crop() method, to just return an empty stub, e.g. for use with crop_to() * cleanup tests and pipeline module to match these changes
axf295
commented
Jul 1, 2026
axf295
left a comment
axf295
left a comment
Collaborator
Author
There was a problem hiding this comment.
I see what you meant w the crop_to now. yes that is nice.
not sure what a lot of the cpp details you've added mean but user-side it looks good!
arahlin
approved these changes
Jul 1, 2026
arahlin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add this bounding box method to flatskymap objects.