Skip to content

[UI] 약관 동의 화면#25

Merged
FLU0RITE merged 8 commits intodevelopfrom
ui/agree
Apr 20, 2025
Merged

[UI] 약관 동의 화면#25
FLU0RITE merged 8 commits intodevelopfrom
ui/agree

Conversation

@FLU0RITE
Copy link
Collaborator

@FLU0RITE FLU0RITE commented Apr 20, 2025

#️⃣연관된 이슈

close #5

📝작업 내용

  • 약관 동의 화면
  • 여성 확인 화면
  • 중간 완료 화면

스크린샷 or 작업영상

Screen_recording_20250420_152539.webm

Simulator Screen Recording - iPhone 16 Plus - 2025-04-20 at 15 56 00

주요 내용

  • dart format을 수행해 체인지가 많아졌습니다!
  • 다음부턴 화면 단위로 끊어 PR을 올리겠습니다!
  • 일단 나중을 위해 말풍선과 폰트를 삭제하지 않았습니다!!

💬다음 작업할 내용

Ios 전화 인증

@FLU0RITE FLU0RITE added the ui Further information is requested label Apr 20, 2025
@FLU0RITE FLU0RITE requested a review from kkosang April 20, 2025 06:37
@FLU0RITE FLU0RITE self-assigned this Apr 20, 2025
Copy link
Collaborator

@kkosang kkosang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿 고생하셨습니다~~!
머지해도 될듯~

ios/Podfile.lock Outdated
Firebase: 1fe1c0a7d9aaea32efe01fbea5f0ebd8d70e53a2
firebase_auth: e37065f3f80ff90580c13ad0e5a48e3bb8d2ad77
firebase_core: 432718558359a8c08762151b5f49bb0f093eb6e0
firebase_auth: ad485af7f854ba5f86634f81725b22b37f317883
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 값들은 왜 다 바뀐건가요..?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

시정하겠습니다!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appbar랑 button같은 경우는 widgets 디렉토리 만들어서 분리되면 좋을것 같아요 !

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵! 바로 반영하겠습니다!

import 'package:flutter_riverpod/flutter_riverpod.dart';

class TermsAndConditionsViewmodel extends ChangeNotifier {
List<bool> state = [false, false, false, false, false];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어떤 state인지 모르겠어요 🤔 조금 더 구체적인 네이밍 사용해주세요~

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵! 반영하겠습니다!

builder: (BuildContext context) {
return Consumer(
builder: (context, ref, _) {
final viewModel = ref.watch(womanViewmodelProvider);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bottomSheet에서 viewModel 처리하는 부분 추후 리펙토링할 때, 변경해야할 듯 싶습니다 !

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵! 알겠습니다!

@FLU0RITE FLU0RITE merged commit a043167 into develop Apr 20, 2025
1 check passed
@FLU0RITE FLU0RITE deleted the ui/agree branch May 10, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants