Skip to content

[FEAT] 애플 로그인 기능 구현#33

Merged
FLU0RITE merged 2 commits intodevelopfrom
feat/apple_login
Apr 25, 2025
Merged

[FEAT] 애플 로그인 기능 구현#33
FLU0RITE merged 2 commits intodevelopfrom
feat/apple_login

Conversation

@FLU0RITE
Copy link
Collaborator

@FLU0RITE FLU0RITE commented Apr 25, 2025

#️⃣연관된 이슈
close #17
📝작업 내용

  • 애플 로그인 구현
  • 로그인 화면 디자인 수정
    스크린샷 or 작업영상
    확인 하신 관계로 영상은 스킵하겠습니다!
스크린샷 2025-04-25 오후 10 54 00

💬리뷰 요구사항

class DefaultLoginRepository implements LoginRepository {
  final LoginRemoteDataSource loginRemoteDataSource;
  final AuthRemoteDataSource authRemoteDataSource;

  DefaultLoginRepository({
    required this.loginRemoteDataSource,
    required this.authRemoteDataSource,
  });

  @override
  Future<User> loginWithKakao() {
    return loginRemoteDataSource.loginWithKakao();
  }

  @override
  Future<User> loginWithApple() {
    throw UnimplementedError();
  }

  @override
  Future<String> loginOauth(String type, String id) {
    return authRemoteDataSource.loginWithOauth(type: type, id: id);
  }
}

애플 로그인 관련 글


https://velog.io/@koomin1227/BE-%EC%97%90%EC%84%9C-%EC%95%A0%ED%94%8C-%EB%A1%9C%EA%B7%B8%EC%9D%B8-

%EA%B5%AC%ED%98%84%ED%95%98%EA%B8%B0

https://dalgoodori.tistory.com/49

리모트에서 어떤 것 하시던데 여기서 저는 뭐 해줄 것이 없는 거 겠죠?
다음 작업
파이어베이스 구현

@FLU0RITE FLU0RITE added the feat Improvements or additions to documentation label Apr 25, 2025
@FLU0RITE FLU0RITE requested a review from kkosang April 25, 2025 13:55
@FLU0RITE FLU0RITE self-assigned this Apr 25, 2025
Copy link
Collaborator

@kkosang kkosang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리모트에서 어떤 것 하시던데 여기서 저는 뭐 해줄 것이 없는 거 겠죠?

loginWithApple()에서 datasource를 통해서 가져올 수 있도록 구조 바꾸면 됩니다 !

+현실 코드리뷰

}
}

Future<void> loginWithApple() async {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분의 로직을 repository로 옮기고 viewmodel에서는 usecase의 함수만 호출하여 가져오도록 분리하면 좋을 것 같아요 !

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵!!!

return MaterialApp(
title: 'Kakao Login Demo',
home: const ProfileInterestPage(),
home: const LoginPage(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@kkosang kkosang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

에러 처리로직 관련해서 다음에 이야기 나눠보고 전체적으로 수정하면 좋을 것 같아요 !
우선 해당 pr은 이정도로 하고 넘어가도 좋을 것 같습니다~

@FLU0RITE FLU0RITE merged commit 31e9b96 into develop Apr 25, 2025
1 check passed
@FLU0RITE FLU0RITE deleted the feat/apple_login branch May 10, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants