Merged
Conversation
kkosang
requested changes
Apr 25, 2025
| } | ||
| } | ||
|
|
||
| Future<void> loginWithApple() async { |
Collaborator
There was a problem hiding this comment.
이 부분의 로직을 repository로 옮기고 viewmodel에서는 usecase의 함수만 호출하여 가져오도록 분리하면 좋을 것 같아요 !
| return MaterialApp( | ||
| title: 'Kakao Login Demo', | ||
| home: const ProfileInterestPage(), | ||
| home: const LoginPage(), |
kkosang
approved these changes
Apr 25, 2025
Collaborator
kkosang
left a comment
There was a problem hiding this comment.
에러 처리로직 관련해서 다음에 이야기 나눠보고 전체적으로 수정하면 좋을 것 같아요 !
우선 해당 pr은 이정도로 하고 넘어가도 좋을 것 같습니다~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
close #17
📝작업 내용
스크린샷 or 작업영상
확인 하신 관계로 영상은 스킵하겠습니다!
💬리뷰 요구사항
애플 로그인 관련 글
https://velog.io/@koomin1227/BE-%EC%97%90%EC%84%9C-%EC%95%A0%ED%94%8C-%EB%A1%9C%EA%B7%B8%EC%9D%B8-
%EA%B5%AC%ED%98%84%ED%95%98%EA%B8%B0 https://dalgoodori.tistory.com/49
리모트에서 어떤 것 하시던데 여기서 저는 뭐 해줄 것이 없는 거 겠죠?
다음 작업
파이어베이스 구현