Open
Conversation
kkosang
requested changes
May 2, 2025
Collaborator
kkosang
left a comment
kkosang
left a comment
There was a problem hiding this comment.
리뷰 남긴 부분만 수정하면 될 것 같습니다 굿굿~
|
|
||
| return Scaffold( | ||
| appBar: SignUpAppBar(currentPage: 10), | ||
| appBar: SignUpAppBar(), |
Collaborator
There was a problem hiding this comment.
이 부분은 다시 currentPage를 넣어줘야 할듯요 !
| class ProfileSummaryPage extends StatelessWidget { | ||
| ProfileSummaryPage({Key? key}) : super(key: key); | ||
| final PageController pageController = PageController(); | ||
| final ValueNotifier<int> currentPageNotifier = ValueNotifier<int>(0); |
Collaborator
There was a problem hiding this comment.
currentPage라는 느낌보다 해당 변수가 사진의 개수를 나타내는거니까.. 음 profileImageIndex 정도..
| ); | ||
| } | ||
|
|
||
| Widget buildProfileFaceImage() { |
Collaborator
There was a problem hiding this comment.
ProfileImage로 통일하면 Face가 먼저 나오는게 좋을 것 같아요 !
Collaborator
There was a problem hiding this comment.
하나의 섹션 단위를 한 파일에 두는 것보다 따로 두는게 더 구조파악하기에 좋을 것 같습니돠
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
close #39
📝작업 내용
작성한 프로필 화면 구현
스크린샷 or 작업영상
Screen_recording_20250429_221507.webm
💬리뷰 요구사항
좀 긴데 분리하긴 했는데 이걸 위젯 디렉토리로 하나하나 분리하는 게 나을까요?
다음 작업
전화번호 인증화면 기능