Open
Conversation
FLU0RITE
added
feat
kkosang
requested changes
May 2, 2025
Collaborator
kkosang
left a comment
kkosang
left a comment
There was a problem hiding this comment.
여기도 패키지 구조만 변경하면 될 것 같습니돠~
굿굿 👍
| int remainingSeconds = 120; | ||
|
|
||
|
|
||
| String formatTime(int seconds) { |
Collaborator
There was a problem hiding this comment.
해당 부분은 viewModel에서 처리하기보다, 도메인 로직이다보니 usecase를 사용하는 구조로 변경하면 좋을 것 같아요 !
| return '$minutes:$remainingSeconds'; | ||
| } | ||
|
|
||
| // 타이머 시작 |
Collaborator
There was a problem hiding this comment.
함수가 길어지면 주석 남기는것도 좋습니다~~ 👍
| } | ||
|
|
||
| @override | ||
| void dispose() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
close #
📝작업 내용
시간초 및 밸리데이터 ui 추가
스크린샷 or 작업영상
Screen_recording_20250430_023410.webm
ios 왜 빌드가 안되죠..
💬리뷰 요구사항