Conversation
# Conflicts: # lib/main.dart
kkosang
approved these changes
May 10, 2025
Collaborator
kkosang
left a comment
kkosang
left a comment
There was a problem hiding this comment.
하나로 관리하니까 확실히 어마무시하긴 하네요..😱
나중에 리펙토링데이 함 하시죠
| final String job; | ||
| final String alcohol; | ||
| final String smoke; | ||
| final List<String> hobby; |
Collaborator
There was a problem hiding this comment.
서버에서 사용하는 Dto와 앱에서 사용하는 프로퍼티의 이름을 따로 사용하고 싶으면 애노테이션을 활용하면 좋을 것 같습니돠 !
| suffixIcon: IconButton( | ||
| icon: Icon(Icons.clear, size: 16), | ||
| onPressed: () => {/*todo 삭제버튼*/}, | ||
| onPressed: () => { |
| alignment: Alignment.centerRight, | ||
| child: Text( | ||
| "${selectedIndexes.length} / $maxSelection", | ||
| "${state.selectedInterestOptions.length} / 5", |
Collaborator
There was a problem hiding this comment.
여기서 maxSelection에서 매직넘버로 바꼈네요 이유가 있나요??
Collaborator
Author
There was a problem hiding this comment.
maxSelection을 지금 생각해 보니까 써야겠네요!
저번엔 따로 관리해야겠다는 차원에서 일단 숫자로 직접 쓴 후 나중에 리펙토링하면서 바꾸려고 했는데
그냥 쓰면 됐겠네요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
close #51
📝작업 내용
스크린샷 or 작업영상
같이 작업하며 확인 완료한 관계로 생략하겠습니다!
💬리뷰 요구사항
리펙토링해야 하는 부분이 있습니다.
viewmodel을 어떻게 분리해야할지 의견 부탁드립니다!