Upgrade Blazor Server AdvancedSearch sample to .NET 8#33
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Upgrade Blazor Server AdvancedSearch sample to .NET 8#33devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Toby Drinkall <toby.drinkall@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
AspNetCore/Blazor/AdvancedSearch.BlazorServer/EqDemo.BlazorServer.AdvancedSearch.csprojfrom .NET 6 to .NET 8 as part of the coordinated multi-session migration. Only this single project is touched; no other.csproj, root files, or sibling projects were modified..csprojchanges<TargetFramework>net6.0net8.0Microsoft.EntityFrameworkCore.Sqlite6.0.18.0.26Microsoft.EntityFrameworkCore.SqlServer6.0.18.0.26Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore6.0.18.0.26Microsoft.Data.SqlClient2.1.75.2.3Microsoft.IdentityModel.JsonWebTokens6.34.07.7.1System.IdentityModel.Tokens.Jwt6.34.07.7.1System.Data.SqlClient4.8.6Microsoft.Data.SqlClient/ .NET 8 BCL)System.Net.Http4.3.4System.Text.RegularExpressions4.3.1System.Drawing.Common4.7.2System.Drawing.Commonwas on the removal list per the task spec; on .NET 8 the type ships in the runtime/shared framework so the explicit reference is no longer needed.Code changes
None required.
_Imports.razorreferences@using System.Net.Http, but the namespace is part of the BCL so removing the package reference does not affect the build. No other source files inAspNetCore/Blazor/AdvancedSearch.BlazorServer/referenced any of the removed packages.Build verification
Ran the following on the VM (using .NET SDK
8.0.420installed viadotnet-install.sh):Result:
CI
CI status will be polled with
git(action="pr_checks", wait_mode="all")after the PR is opened and reported in the final session message.Review & Testing Checklist for Human
dotnet build -c ReleaseonEqDemo.BlazorServer.AdvancedSearch.csprojsucceeds in your environment with the .NET 8 SDK.SqlServerprovider (Microsoft.Data.SqlClient bumped from 2.1.7 → 5.2.3 — connection strings using legacy encryption defaults may needEncrypt=Falseor a server cert update; see Microsoft.Data.SqlClient 4.0+ breaking changes).Notes
.csprojlisted above. Noglobal.json,Directory.Build.props,.sln, or other projects were touched.8.0.x/5.2.x/7.xavailable on NuGet.org at the time of the upgrade.Link to Devin session: https://app.devin.ai/sessions/f94354c6acc24c58906392b70ccdc031
Requested by: @tobydrinkall
Devin Review