Add .NET 8 root infrastructure (global.json + Directory.Build.props)#34
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Add .NET 8 root infrastructure (global.json + Directory.Build.props)#34devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- global.json pins the .NET SDK to 8.0.300 with rollForward=latestFeature so any 8.0.x SDK >= 8.0.300 is acceptable but no .NET 9+ SDK is silently picked up. - Directory.Build.props sets LangVersion=latest for all projects in the repo. Intentionally minimal: no Nullable or ImplicitUsings so legacy (.NET Framework / older TFM) projects keep building. Co-Authored-By: Toby Drinkall <toby.drinkall@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two repo-root infrastructure files in support of the broader .NET 8 upgrade work happening across this repo. No
.csproj,.sln, or source files are touched.Files added
global.json{"sdk":{"version":"8.0.300","rollForward":"latestFeature"}}Pins the .NET SDK to 8.0.300 with
rollForward: latestFeature, so any 8.0.x SDK ≥ 8.0.300 is acceptable but no .NET 9+ SDK will be silently picked up.Directory.Build.propsSets
LangVersion=latestfor every project in the repo. Kept minimal on purpose — no<Nullable>or<ImplicitUsings>because legacy (.NET Framework, older TFM) projects still live in this repo and would break under those settings.Code changes
None. Diff is exactly the two new root-level files.
Build / verification
After installing the .NET 8 SDK on a clean VM via
dotnet-install.sh --version 8.0.300:This confirms:
global.jsonresolves to a real, installed SDK.Directory.Build.propsis picked up automatically and does not break a representativenet8.0project.No
.csproj/lockfile/build-artifact changes from that test build were committed —bin/andobj/are gitignored, so the PR diff is exactly the two files described above.Review & Testing Checklist for Human
Risk: green (config-only, no source changes).
global.jsonandDirectory.Build.propsat the repo root (no.csproj,.sln, or source file changes).8.0.300is an acceptable floor for everyone working on this repo. WithrollForward: latestFeature, any 8.0.x ≥ 8.0.300 will satisfy it; .NET 9+ SDKs will be rejected.<LangVersion>lower thanlatest(very unlikely to be a problem in practice —latestis permissive).Notes
global.jsonis intentionally a single-line file matching the exact content specified by the parent task.Link to Devin session: https://app.devin.ai/sessions/0fb1d9c0e883407cbd9e16cf3f81dbca
Requested by: @tobydrinkall
Devin Review