-
Notifications
You must be signed in to change notification settings - Fork 0
chore(net8): upgrade AspNetCore/Vue2/AdvancedSearch to .NET 8 #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
518a689
037108b
a43169e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,8 +7,6 @@ | |
| using Microsoft.Extensions.Hosting; | ||
| using Microsoft.EntityFrameworkCore; | ||
|
|
||
| using VueCliMiddleware; | ||
|
|
||
| using Korzh.EasyQuery.Services; | ||
| using EasyData.Export; | ||
|
|
||
|
|
@@ -44,12 +42,6 @@ public void ConfigureServices(IServiceCollection services) | |
|
|
||
| services.AddControllersWithViews(); | ||
|
|
||
| // In production, the React files will be served from this directory | ||
| services.AddSpaStaticFiles(configuration => | ||
| { | ||
| configuration.RootPath = "ClientApp/dist"; | ||
| }); | ||
|
|
||
| services.AddEasyQuery() | ||
| .UseSqlManager() | ||
| .AddDefaultExporters() | ||
|
|
@@ -78,11 +70,7 @@ public void Configure(IApplicationBuilder app, IWebHostEnvironment env) | |
|
|
||
| app.UseHttpsRedirection(); | ||
| app.UseStaticFiles(); | ||
| if (!env.IsDevelopment()) { | ||
| app.UseSpaStaticFiles(); | ||
| } | ||
|
|
||
|
|
||
| app.UseRouting(); | ||
|
|
||
| app.UseEndpoints(endpoints => | ||
|
|
@@ -103,24 +91,10 @@ public void Configure(IApplicationBuilder app, IWebHostEnvironment env) | |
| endpoints.MapControllerRoute( | ||
| name: "default", | ||
| pattern: "{controller}/{action=Index}/{id?}"); | ||
| }); | ||
|
|
||
| app.UseSpa(spa => | ||
| { | ||
| spa.Options.SourcePath = "ClientApp"; | ||
| spa.Options.StartupTimeout = TimeSpan.FromMinutes(2); | ||
|
|
||
| if (env.IsDevelopment()) | ||
| { | ||
| // run npm process with client app | ||
| spa.UseVueCli(npmScript: "serve", port: 8085, regex: "Compiled "); | ||
| // if you just prefer to proxy requests from client app, use proxy to SPA dev server instead: | ||
| // app should be already running before starting a .NET client | ||
| // spa.UseProxyToSpaDevelopmentServer("http://localhost:8080"); // your Vue app port | ||
| } | ||
| endpoints.MapFallbackToFile("index.html"); | ||
|
devin-ai-integration[bot] marked this conversation as resolved.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 Missing Vue dev server proxy configuration breaks API calls in development mode The migration from Prompt for agentsWas this helpful? React with 👍 or 👎 to provide feedback.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Acknowledged — this is a real concern but it is intentionally out of scope for this PR. The parent task spec states:
A Since this is a For production, the just-pushed fix to |
||
| }); | ||
|
|
||
|
|
||
| //Init demo database (if necessary) | ||
| app.EnsureDbInitialized(Configuration, env); | ||
| } | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.