Upgrade Vue3/AdvancedSearch.Server to .NET 8#38
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Upgrade Vue3/AdvancedSearch.Server to .NET 8#38devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- Bump TFM to net8.0 - Bump Microsoft.EntityFrameworkCore.Sqlite/SqlServer to 8.0.26 - Bump Microsoft.AspNetCore.SpaProxy to 8.0.26 - Remove Microsoft.AspNetCore.SpaServices.Extensions (deprecated in .NET 8); SpaProxy MSBuild props remain for dev-time proxy - Remove Newtonsoft.Json (no source usages; System.Text.Json from BCL covers any future needs) - Remove System.Data.SqlClient, System.Net.Http, System.Text.RegularExpressions (provided by .NET 8 BCL) - Remove dead UseSpa/UseSpaStaticFiles commented blocks in Startup.cs that referenced deprecated SpaServices.Extensions APIs Co-Authored-By: Toby Drinkall <toby.drinkall@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the single project
AspNetCore/Vue3/AdvancedSearch.Serverfrom .NET 6 to .NET 8 per the parent task scope. No other projects/files are touched..csprojchanges —AspNetCore/Vue3/AdvancedSearch.Server/AdvancedSearch.Server.csprojTargetFrameworknet6.0net8.0Microsoft.EntityFrameworkCore.Sqlite6.0.18.0.26Microsoft.EntityFrameworkCore.SqlServer6.0.18.0.26Microsoft.AspNetCore.SpaProxy6.*-*8.0.26Microsoft.AspNetCore.SpaServices.Extensions6.0.1Newtonsoft.Json13.0.3System.Text.Jsoncovers needs; no source usages existed in this project)System.Data.SqlClient4.8.6System.Net.Http4.3.4System.Text.RegularExpressions4.3.1Other packages (
Korzh.DbUtils.*,EasyData.Exporters.*,Korzh.EasyQuery.*) are intentionally untouched per scope rules. The existing<SpaProxyServerUrl>/<SpaProxyLaunchCommand>MSBuild properties remain — they are howMicrosoft.AspNetCore.SpaProxy 8.0.xwires up the dev-time proxy to the Vite dev server.Code changes —
AspNetCore/Vue3/AdvancedSearch.Server/Startup.csapp.UseSpaStaticFiles()block (lines that referenced the now-removedMicrosoft.AspNetCore.SpaServices.Extensions).app.UseSpa(spa => { ... spa.UseVueCli(...); spa.UseProxyToSpaDevelopmentServer(...); });block (same reason).Rationale: with
SpaServices.Extensionsremoved, those commented references are misleading —SpaProxy(kept) handles dev-time proxy via the MSBuild properties, and production serves static files fromwwwrootvia the existingapp.UseStaticFiles(). No active code paths changed.No
Newtonsoft.Jsonusages existed in the C# source underAspNetCore/Vue3/AdvancedSearch.Server/— only the<PackageReference>was present, so removing the package required no code edits.Program.csis unchanged (it already usesHost.CreateDefaultBuilderwhich is fully supported in .NET 8).Build commands and result
Result on local VM (.NET SDK 8.0.420):
All 61 warnings are pre-existing CS8618 / CS8602 nullable-reference-type warnings in
Models/NWind/*.csandSeed/DbInitializeExtensions.cs. They are unrelated to the .NET 8 upgrade —<Nullable>enable</Nullable>was already set onmaster, the model classes simply don't declare therequiredmodifier or nullable types. Out of scope to fix here.CI status
To be reported in the final session message after polling via
git(action="pr_checks", wait_mode="all").Review & Testing Checklist for Human
Risk: yellow (single project, mechanical package bump + dead-code removal, but transitive impact on EasyQuery / EF Core 6 → 8 compatibility is worth a runtime smoke).
dotnet run --project AspNetCore/Vue3/AdvancedSearch.Server) and confirm the EasyQuery endpoints (/api/easyquery/*) still respond and the demo SQLite DB initializes viaapp.EnsureDbInitialized(...).Microsoft.AspNetCore.SpaProxy 8.0.xdev-time proxy still launches the Vite client via<SpaProxyLaunchCommand>npm run dev</SpaProxyLaunchCommand>onhttps://localhost:5173.Notes
AspNetCore/Vue3/AdvancedSearch.Server/. No.sln,Directory.Build.props,global.json, sibling project, orClientApp/files were modified.Microsoft.EntityFrameworkCore.SqlServerwas bumped to match the Sqlite version even though it isn't actively wired inStartup.cs(UseSqlServeris commented), to keep the EF Core stack on a single 8.0.x line.Link to Devin session: https://app.devin.ai/sessions/1941d467ab9a45c4bf4750b00d8fead1
Requested by: @tobydrinkall
Devin Review