Integrate Temporal .NET SDK into AdvancedSearch project#41
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Integrate Temporal .NET SDK into AdvancedSearch project#41devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- Add Temporalio and Temporalio.Extensions.Hosting NuGet packages - Create WeatherActivities with durable activity for weather data - Create WeatherWorkflow to orchestrate weather forecast generation - Register Temporal client and hosted worker in Startup.cs DI - Update SampleDataController to start Temporal workflow - Add docker-compose.yml for local Temporal server and UI
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates the Temporal .NET SDK into the
AspNetCore/React/AdvancedSearchproject, wrapping the existing weather forecast generation in durable Temporal workflows.Changes:
TemporalioandTemporalio.Extensions.Hostingv1.5.0 NuGet packagesWorkflows/WeatherActivities.cs— Temporal activity that generates weather forecast dataWorkflows/WeatherWorkflow.cs— Temporal workflow that orchestrates the activityStartup.cs— registered Temporal client (configurable viaTemporal:TargetHostandTemporal:Namespacein appsettings) and a hosted worker onadvanced-search-task-queueSampleDataController.cs—WeatherForecastsendpoint now starts a Temporal workflow and awaits its result instead of generating data inlinedocker-compose.ymlfor running Temporal server + UI locallyThe React frontend (
FetchData.js) requires no changes — the API contract is unchanged.Review & Testing Checklist for Human
docker-compose upinAspNetCore/React/AdvancedSearch/before running the appapi/SampleData/WeatherForecastsreturns forecast data through the Temporal workflowhttp://localhost:8080to verify workflows are executing onadvanced-search-task-queueRecommended test plan:
cd AspNetCore/React/AdvancedSearch && docker-compose up -ddotnet runhttp://localhost:8080to inspect completed workflows in the Temporal UINotes
WeatherForecastmodel has been moved fromSampleDataControllerintoWeatherActivitiesto be accessible by the workflow. The data shape is identical.appsettings.jsonunderTemporal:TargetHostandTemporal:Namespace, defaulting tolocalhost:7233anddefault.MapEasyQuery) is left untouched — wrapping it in Temporal would require a larger refactor as noted in the task description.Link to Devin session: https://app.devin.ai/sessions/789b80c8cdc04eae84abcbc1a849c94f
Requested by: @TheWuster935
Devin Review