COG-559: Phase 1 — pom.xml Dependency and Build Configuration Updates#20
Open
devin-ai-integration[bot] wants to merge 5 commits into
Open
COG-559: Phase 1 — pom.xml Dependency and Build Configuration Updates#20devin-ai-integration[bot] wants to merge 5 commits into
devin-ai-integration[bot] wants to merge 5 commits into
Conversation
…move junit-vintage exclusion
…into devin/cog-559-phase1-base
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the monolith to Spring Boot 3.4.5 / Java 21 with all required dependency and source code migrations.
pom.xml changes (4 items per ticket):
java.version11 → 21spring-boot-starter-parent2.2.6.RELEASE → 3.4.5org.apache.httpcomponents:httpclient→org.apache.httpcomponents.client5:httpclient5junit-vintage-engineexclusion block (unnecessary in Spring Boot 3)Additional required changes for Spring Boot 3 compatibility:
spring-boot-starter-validationdependency (jakarta.validation is no longer transitively included)javax.persistence→jakarta.persistenceimports (5 files)javax.validation→jakarta.validationimports (5 files)org.apache.hc.client5.http.impl.classic.*) inSplitTheMonolithApplication.javaChild sessions used:
Resolves COG-559
Review & Testing Checklist for Human
cd monolith && ./mvnw spring-boot:run(Java 21 required)cd monolith && ./mvnw clean test/counterparties,/bonds,/rfqs) and confirm seed data loads correctlyjavax.persistenceorjavax.validationimports exist in the codebaseNotes
spring-boot-starter-validationaddition was required because Spring Boot 3 no longer transitively provides the Jakarta Bean Validation APILink to Devin session: https://app.devin.ai/sessions/668bfd7cf03b49bbac7374714f007966
Requested by: @patrickbradley-cog
Devin Review