Skip to content

COG-559: Phase 1 — pom.xml Dependency and Build Configuration Updates#20

Open
devin-ai-integration[bot] wants to merge 5 commits into
masterfrom
devin/cog-559-phase1-base
Open

COG-559: Phase 1 — pom.xml Dependency and Build Configuration Updates#20
devin-ai-integration[bot] wants to merge 5 commits into
masterfrom
devin/cog-559-phase1-base

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented May 29, 2026

Copy link
Copy Markdown

Summary

Upgrades the monolith to Spring Boot 3.4.5 / Java 21 with all required dependency and source code migrations.

pom.xml changes (4 items per ticket):

  1. java.version 11 → 21
  2. spring-boot-starter-parent 2.2.6.RELEASE → 3.4.5
  3. org.apache.httpcomponents:httpclientorg.apache.httpcomponents.client5:httpclient5
  4. Removed junit-vintage-engine exclusion block (unnecessary in Spring Boot 3)

Additional required changes for Spring Boot 3 compatibility:

  • Added spring-boot-starter-validation dependency (jakarta.validation is no longer transitively included)
  • Migrated all javax.persistencejakarta.persistence imports (5 files)
  • Migrated all javax.validationjakarta.validation imports (5 files)
  • Migrated httpclient imports to httpclient5 (org.apache.hc.client5.http.impl.classic.*) in SplitTheMonolithApplication.java

Child sessions used:

  • PR #14 — javax → jakarta namespace migration
  • PR #13 — httpclient → httpclient5 source code migration

Resolves COG-559

Review & Testing Checklist for Human

  • Verify the app starts successfully with cd monolith && ./mvnw spring-boot:run (Java 21 required)
  • Verify all 7 integration tests pass: cd monolith && ./mvnw clean test
  • Hit REST endpoints (/counterparties, /bonds, /rfqs) and confirm seed data loads correctly
  • Confirm no remaining javax.persistence or javax.validation imports exist in the codebase

Notes

  • Build and all 7 tests verified passing locally on Java 21 (OpenJDK 21.0.2)
  • The spring-boot-starter-validation addition was required because Spring Boot 3 no longer transitively provides the Jakarta Bean Validation API

Link to Devin session: https://app.devin.ai/sessions/668bfd7cf03b49bbac7374714f007966
Requested by: @patrickbradley-cog


Devin Review

Status Commit
⚪ Not started

Run Devin Review

💡 Connect your GitHub account to enable automatic code reviews.

Open in Devin Review (Staging)
Open in Devin Review

@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant