Wave 4: angular-eslint migration, remove protractor e2e, headless unit tests #418
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| // @ts-check | ||
| const eslint = require("@eslint/js"); | ||
| const { defineConfig } = require("eslint/config"); | ||
| const tseslint = require("typescript-eslint"); | ||
| const angular = require("angular-eslint"); | ||
|
|
||
| module.exports = defineConfig([ | ||
| { | ||
| files: ["**/*.ts"], | ||
| extends: [ | ||
| eslint.configs.recommended, | ||
| tseslint.configs.recommended, | ||
| tseslint.configs.stylistic, | ||
| angular.configs.tsRecommended, | ||
| ], | ||
| processor: angular.processInlineTemplates, | ||
| rules: { | ||
| "@angular-eslint/directive-selector": [ | ||
| "error", | ||
| { | ||
| type: "attribute", | ||
| prefix: "app", | ||
| style: "camelCase", | ||
| }, | ||
| ], | ||
| "@angular-eslint/component-selector": [ | ||
| "error", | ||
| { | ||
| type: "element", | ||
| prefix: "app", | ||
| style: "kebab-case", | ||
| }, | ||
| ], | ||
| // Legacy NgModule-based codebase; standalone/inject migrations are out of scope | ||
| "@angular-eslint/prefer-standalone": "off", | ||
| "@angular-eslint/prefer-inject": "off", | ||
| "@angular-eslint/no-empty-lifecycle-method": "off", | ||
| "@typescript-eslint/no-empty-function": "off", | ||
| "@typescript-eslint/no-unused-vars": "off", | ||
| "@typescript-eslint/no-explicit-any": "off", | ||
| "@typescript-eslint/no-unsafe-function-type": "off", | ||
| "prefer-const": "off", | ||
|
Comment on lines
+37
to
+42
There was a problem hiding this comment. 📝 Info: ESLint config disables several useful lint rules The new ESLint config disables a broad set of rules: 
Was this helpful? React with 👍 or 👎 to provide feedback. There was a problem hiding this comment. Acknowledged — these are set to |
||
| }, | ||
| }, | ||
| { | ||
| files: ["**/*.html"], | ||
| extends: [ | ||
| angular.configs.templateRecommended, | ||
| angular.configs.templateAccessibility, | ||
| ], | ||
| rules: { | ||
| // Structural-directive templates predate built-in control flow | ||
| "@angular-eslint/template/prefer-control-flow": "off", | ||
| "@angular-eslint/template/click-events-have-key-events": "off", | ||
| "@angular-eslint/template/interactive-supports-focus": "off", | ||
| }, | ||
| } | ||
| ]); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 Production build has sourceMap and namedChunks enabled
The production configuration in
angular.json:46-47has"sourceMap": trueand"namedChunks": true. These are typically disabled in production builds for performance and bundle size reasons. This is pre-existing (not changed by this PR), but worth noting as it increases the production bundle size and exposes source code.(Refers to lines 46-47)
Was this helpful? React with 👍 or 👎 to provide feedback.