Skip to content

fix: Wave 3 — Sass deprecations, deep combinator, and template fixes #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tobydrinkall wants to merge 2 commits into
base: upgrade/angular-core
Choose a base branch
from
Open

fix: Wave 3 — Sass deprecations, deep combinator, and template fixes #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14dfbd6
fix: resolve Sass deprecations and CSS deep combinator issues
devin-ai-integration[bot] Jul 2, 2026
952822b
fix: preserve :host scoping with ::ng-deep to prevent style leaks
devin-ai-integration[bot] Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/app.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import "./shared/scss/media";
@import "./shared/scss/theme_variables";
@use "./shared/scss/media" as *;
@use "./shared/scss/theme_variables" as *;

.body-cover {
width: 100%;
Expand Down
4 changes: 2 additions & 2 deletions src/app/core/footer/footer.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import "../../shared/scss/media";
@import "../../shared/scss/theme_variables";
@use "../../shared/scss/media" as *;
@use "../../shared/scss/theme_variables" as *;

#footer {
position: relative;
Expand Down
4 changes: 2 additions & 2 deletions src/app/core/header/header.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import "../../shared/scss/media";
@import "../../shared/scss/theme_variables";
@use "../../shared/scss/media" as *;
@use "../../shared/scss/theme_variables" as *;

#header {
color: #fff;
Expand Down
4 changes: 2 additions & 2 deletions src/app/core/settings/settings.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import "../../shared/scss/media";
@import "../../shared/scss/theme_variables";
@use "../../shared/scss/media" as *;
@use "../../shared/scss/theme_variables" as *;

.overlay {
position: fixed;
Expand Down
4 changes: 2 additions & 2 deletions src/app/feeds/feed/feed.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import "../../shared/scss/media";
@import "../../shared/scss/theme_variables";
@use "../../shared/scss/media" as *;
@use "../../shared/scss/theme_variables" as *;

a {
text-decoration: none;
Expand Down
4 changes: 2 additions & 2 deletions src/app/feeds/item/item.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import "../../shared/scss/media";
@import "../../shared/scss/theme_variables";
@use "../../shared/scss/media" as *;
@use "../../shared/scss/theme_variables" as *;

p {
margin: 2px 0;
Expand Down
6 changes: 3 additions & 3 deletions src/app/item-details/comment/comment.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@import "../../shared/scss/media";
@import "../../shared/scss/theme_variables";
@use "../../shared/scss/media" as *;
@use "../../shared/scss/theme_variables" as *;

:host >>> {
:host ::ng-deep {
a {
font-weight: bold;
text-decoration: none;
Expand Down
4 changes: 2 additions & 2 deletions src/app/item-details/item-details.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import "../shared/scss/media";
@import "../shared/scss/theme_variables";
@use "../shared/scss/media" as *;
@use "../shared/scss/theme_variables" as *;

.main-content {
position: relative;
Expand Down
13 changes: 7 additions & 6 deletions src/app/shared/components/error-message/error-message.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
@import "../../scss/media";
@import "../../scss/theme_variables";
@use "sass:math";
@use "../../scss/media" as *;
@use "../../scss/theme_variables" as *;

.error-section {
height: 300px;
Expand Down Expand Up @@ -65,9 +66,9 @@
content: "";
position: absolute;
top: 100%;
left: $skull-size / 15;
border-right: $skull-size / 20 solid transparent;
border-left: $skull-size / 40 solid transparent;
left: math.div($skull-size, 15);
border-right: math.div($skull-size, 20) solid transparent;
border-left: math.div($skull-size, 40) solid transparent;
}
}
}
Expand All @@ -77,7 +78,7 @@
position: absolute;
top: 75%;
left: 30%;
border-radius: 0 0 $skull-size / 10 $skull-size / 10;
border-radius: 0 0 math.div($skull-size, 10) math.div($skull-size, 10);
&:before {
content: "";
position: absolute;
Expand Down
4 changes: 2 additions & 2 deletions src/app/shared/components/loader/loader.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@import "../../scss/media";
@import "../../scss/theme_variables";
@use "../../scss/media" as *;
@use "../../scss/theme_variables" as *;

.loader {
-webkit-animation: load1 1s infinite ease-in-out;
Expand Down
12 changes: 7 additions & 5 deletions src/app/shared/scss/_themes.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
@import "./media";
@import "./theme_variables";
@use "sass:math";
@use "sass:color";
@use "./media" as *;
@use "./theme_variables" as *;

/* ----------------------------------

Expand Down Expand Up @@ -142,10 +144,10 @@
}

&:before {
border-top: $skull-size / 8 solid $wrapper-background-color;
border-top: math.div($skull-size, 8) solid $wrapper-background-color;

@media #{$mobile-only} {
border-top: $skull-size / 8 solid $wrapper-mobile-background-color;
border-top: math.div($skull-size, 8) solid $wrapper-mobile-background-color;
}
}
}
Expand Down Expand Up @@ -230,7 +232,7 @@
$theme-amoledblack-body-background-color,
$theme-amoledblack-text-color,
$theme-amoledblack-text-color,
darken($theme-amoledblack-text-color, 33%),
color.adjust($theme-amoledblack-text-color, $lightness: -33%),

@devin-ai-integration devin-ai-integration Bot Jul 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: darken() to color.adjust() conversion is semantically equivalent

The conversion from darken($theme-amoledblack-text-color, 33%) to color.adjust($theme-amoledblack-text-color, $lightness: -33%) at src/app/shared/scss/_themes.scss:235 is correct. Sass's darken($color, $amount) is defined as equivalent to color.adjust($color, $lightness: -$amount) — both subtract the given percentage points from the HSL lightness value. The input color $theme-amoledblack-text-color is rgba(255, 255, 255, 0.75) (defined at src/app/shared/scss/_theme_variables.scss:35), which has lightness 100%, so subtracting 33 percentage points yields lightness 67% — identical behavior to the original.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

$theme-amoledblack-body-background-color,
$theme-amoledblack-subtext-color,
$theme-amoledblack-secondary-color,
Expand Down
6 changes: 3 additions & 3 deletions src/app/user/user.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@import "../shared/scss/media";
@import "../shared/scss/theme_variables";
@use "../shared/scss/media" as *;
@use "../shared/scss/theme_variables" as *;

:host >>> pre {
:host ::ng-deep pre {
white-space: pre-wrap;
}

Expand Down
2 changes: 1 addition & 1 deletion src/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import "./app/shared/scss/themes";
@use "./app/shared/scss/themes";

@devin-ai-integration devin-ai-integration Bot Jul 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 *Info: styles.scss uses @use without 'as ' correctly for side-effect-only import

The @use "./app/shared/scss/themes" at src/styles.scss:1 intentionally omits as * because this file doesn't need to access any variables or mixins from the themes partial — it only needs the CSS output generated by the @include theme(...) calls within _themes.scss. The default namespaced import (accessible as themes.$var if needed) is fine here since no members are referenced. This differs from the component SCSS files which use as * to access $mobile-only, $laptop-only, etc. without a namespace prefix.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.


html {
height: 100%;
Expand Down