-
Notifications
You must be signed in to change notification settings - Fork 1
Add .agents/environment.yaml for automated dev setup #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devin-ai-integration
wants to merge
1
commit into
master
Choose a base branch
from
devin/1773324444-add-environment-config
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| # See spec at https://docs.devin.ai/onboard-devin/repo-setup | ||
| # This repo contains companion code for the "Testing Angular Applications" book. | ||
| # It is organized by chapter, each with its own package.json and dependencies. | ||
| # The main runnable Angular app is in the "website" directory. | ||
| # Requires Node.js 8 (Angular 5.x era project). | ||
| initialize: | | ||
| # Install Node 8 via nvm (required for this Angular 5.x project) | ||
| export NVM_DIR="$HOME/.nvm" | ||
| [ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh" | ||
| nvm install 8 | ||
| maintenance: | | ||
| export NVM_DIR="$HOME/.nvm" | ||
| [ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh" | ||
| nvm use 8 | ||
| # Install dependencies for the main website app | ||
| (cd website && npm install) | ||
| # Install dependencies for chapter projects used in CI | ||
| (cd chapter08 && npm install) | ||
| (cd chapter09 && npm install) | ||
| (cd chapter11 && npm install) | ||
| knowledge: | ||
| - name: lint | ||
| contents: | | ||
| # Lint the website app | ||
| (cd website && npx ng lint) | ||
| - name: test | ||
| contents: | | ||
| # Unit tests for the website app (requires Chrome/Chromium) | ||
| (cd website && npx ng test --watch=false) | ||
| - name: startup | ||
| contents: | | ||
| # Start the website dev server (Contacts app) on port 4200 | ||
| export NVM_DIR="$HOME/.nvm" && [ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh" && nvm use 8 | ||
| (cd website && npx ng serve --port 4200) | ||
| - name: notes | ||
| contents: | | ||
| # Repo structure: each chapter (chapter01-chapter11) is a separate sub-project. | ||
| # The "website" directory is the main Angular Contacts app (Angular 5.x). | ||
| # Chapters 06/07 have pre-existing build errors (Angular Material API changes). | ||
| # Chapters 08/09/10/11 contain Protractor e2e tests. | ||
| # CI runs on chapter08, chapter09, chapter10/*, and chapter11 (see .circleci/config.yml). | ||
| # Must use Node 8 via nvm for all operations. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Maintenance step missing chapter10 dependency installation that CI requires
The
maintenancesection installs dependencies forchapter08,chapter09, andchapter11, but omitschapter10subdirectories. The CI config at.circleci/config.ymlinstalls and runs tests forchapter10/test_capabilities,chapter10/test_multicapabilities, andchapter10/test_plugins. Thenotessection at line 41 even acknowledges this: "CI runs on chapter08, chapter09, chapter10/*, and chapter11", yet the maintenance step doesn't install any chapter10 dependencies, so any Devin task involving chapter10 e2e tests will fail.Was this helpful? React with 👍 or 👎 to provide feedback.