implemented army biz scenario by estigoldberger · Pull Request #27 · CPU-Code-School/cpu-biz-scenario

estigoldberger · 2023-03-15T19:32:54Z

I implemented the Army Biz-Scenario.

ghost

Excellent! Some changes needed. See comments on PR, fix and resubmit.

ghost · 2023-03-15T21:22:45Z

+    SoldierID int not null identity primary key,
+    FirstName varchar (30) not null constraint first_name_cannot_be_blank check (FirstName <> ''),
+    LastName  varchar (30) not null constraint last_name_cannot_be_blank check (LastName <> ''),
+    SSN char (10) not null constraint ck_ssn_10_characters check (len (SSN) = 10)


len(SSN) is not enough when using char(10), as this adds extra spaces and it will always be 10 characters. Remove trailing/leading spaces and then check the len()

I'm not quite sure what you mean. Can you explain?

Can you tell me how to do it?

Sorry, I thought it was necessary, but I tried it and saw that SQL is restricting to insert even when inserting spaces.

ghost · 2023-03-15T21:23:41Z

+    SSN char (10) not null constraint ck_ssn_10_characters check (len (SSN) = 10)
+        constraint u_SSN_must_be_Unique unique,
+    DOB date not null ,
+    DateOfEnlistment date not null,


Don't allow future dates.

ghost · 2023-03-15T21:26:29Z

+    PlaceOfResidence varchar (50) not null constraint ck_POR_cannot_be_blank check (PlaceOfResidence <> ''),
+    ServiceUnit varchar(20) not null constraint ck_serviceunit_navy_land_or_air check (ServiceUnit in ('Navy', 'Ground Force', 'Air Force')),
+    SoldierRank varchar (50) not null constraint ck_soldier_rank_cannot_be_blank check (SoldierRank <> ''),
+    IQLevel int not null,


Cannot be negative. And maybe don't allow more than max IQ level.

What is the max IQ level? I tried to google but didn't get concrete answer

It's ok, maybe use 200

ghost · 2023-03-15T21:27:48Z

+order by IQLevel desc 
+
+--2) I need a list of all soldiers sorted by age at enlistment from high to low. Do not include columns that are not relevant to this list.
+select LastName, FirstName, Age= year(DateOfEnlistment)-year(DOB)


There's a better way to check diff in dates.

I fixed this

ghost · 2023-03-15T21:28:56Z

+where YearRange = '2017-2019'
+union select Recruitment =concat(YearRange, ', ', FirstName, ' ', LastName, ' - ', SSN, ' ', '(',  DateOfEnlistment, ')', ', ',  ServiceUnit)
+from soldiers s 
+where YearRange = '2020-2022'


Maybe sort in order

In order of what?

For example, year. It should be in sensible order.

ghost · 2023-03-15T21:33:24Z

+    ServiceUnit varchar(20) not null constraint ck_serviceunit_navy_land_or_air check (ServiceUnit in ('Navy', 'Ground Force', 'Air Force')),
+    SoldierRank varchar (50) not null constraint ck_soldier_rank_cannot_be_blank check (SoldierRank <> ''),
+    IQLevel int not null,
+    constraint  ck_Soldier_must_be_at_least_17 check (year(DateOfEnlistment) - year(DOB) >=17)  


There's a better way to check diff in dates.

I fixed this

ghost

Looks good, see comments. No need to resubmit.

ghost · 2023-03-16T15:01:43Z

+    SoldierID int not null identity primary key,
+    FirstName varchar (30) not null constraint first_name_cannot_be_blank check (FirstName <> ''),
+    LastName  varchar (30) not null constraint last_name_cannot_be_blank check (LastName <> ''),
+    SSN char (10) not null constraint ck_ssn_10_characters check (len (SSN) = 10)


Sorry, I thought it was necessary, but I tried it and saw that SQL is restricting to insert even when inserting spaces.

ghost · 2023-03-16T15:09:55Z

+    PlaceOfResidence varchar (50) not null constraint ck_POR_cannot_be_blank check (PlaceOfResidence <> ''),
+    ServiceUnit varchar(20) not null constraint ck_serviceunit_navy_land_or_air check (ServiceUnit in ('Navy', 'Ground Force', 'Air Force')),
+    SoldierRank varchar (50) not null constraint ck_soldier_rank_cannot_be_blank check (SoldierRank <> ''),
+    IQLevel int not null,


It's ok, maybe use 200

ghost · 2023-03-16T15:11:13Z

+where YearRange = '2017-2019'
+union select Recruitment =concat(YearRange, ', ', FirstName, ' ', LastName, ' - ', SSN, ' ', '(',  DateOfEnlistment, ')', ', ',  ServiceUnit)
+from soldiers s 
+where YearRange = '2020-2022'


For example, year. It should be in sensible order.

implemented army biz scenario

f9c287a

ghost suggested changes Mar 15, 2023

View reviewed changes

implemented army biz-scenario

de98e31

ghost reviewed Mar 16, 2023

View reviewed changes

Conversation

estigoldberger commented Mar 15, 2023

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost left a comment • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ghost left a comment •

edited by ghost

Loading