Skip to content

implemented the costume scenario#30

Open
SuriKandler wants to merge 2 commits into
CPU-Code-School:mainfrom
SuriKandler:main
Open

implemented the costume scenario#30
SuriKandler wants to merge 2 commits into
CPU-Code-School:mainfrom
SuriKandler:main

Conversation

@SuriKandler
Copy link
Copy Markdown

Please find my homework.
Let me know if its all ok.

Comment thread 1.table.sql
Comment thread 1.table.sql Outdated
Comment thread 1.table.sql
Comment thread 1.table.sql Outdated
constraint ck_quantity_must_be_at_least_1 check(Quantity > 0),
PriceSoldPerCostume int not null
constraint ck_price_sold_per_costume_there_are_fixed_prices check(PriceSoldPerCostume in (15,17,20,22,25,27,30)),
DateBought date not null,
Copy link
Copy Markdown
Contributor

@AvigailGellis AvigailGellis May 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AS: -3 DateBought must be after the bussiness opened. Once you have this constraint then the only constraint you need on DateSold is that it should be between DateBought and current date. All multi column constraints belong at the end of the table.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the amendments. On the spec it mentioned that she was supplying fam and friends before the business opened - is that not a reason not to have the date bought constraint after the business opened?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would assume that would not be included in the db since that was before it becase an official business.

Comment thread 1.table.sql Outdated
Comment thread 1.table.sql
Comment thread 2.data.sql Outdated
Comment thread 3.reports.sql
Copy link
Copy Markdown
Contributor

@AvigailGellis AvigailGellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AS: Great job! 88% Please see comments and resubmit.

@SuriKandler
Copy link
Copy Markdown
Author

I have made the requested changes, please review.
Thanks

Copy link
Copy Markdown
Contributor

@AvigailGellis AvigailGellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job! 100%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants