Implemented the Cleaning Company Scenario by RiFinkelstein · Pull Request #35 · CPU-Code-School/cpu-biz-scenario

RiFinkelstein · 2023-11-05T19:45:10Z

I have created a database and implemented the Cleaning Company Scenario

ghost

Excellent work! See comments, fix and resubmit.

ghost · 2023-11-06T20:20:49Z

+drop TABLE if EXISTS dbo.CleaningCompany
+go
+CREATE table dbo.CleaningCompany(
+        CustomerID int not null IDENTITY primary key,


The PK should be the name of the table + Id. Either change the table name or the PK column name.

I switched the tablename

ghost · 2023-11-06T20:24:37Z

+        FirstName varchar(50) not null constraint ck_Customer_First_name_is_not_blank CHECK (FirstName <> ''), 
+        LastName varchar(50) not null constraint ck_Customer_Last_name_is_not_blank CHECK (LastName <> ''), 
+        PhoneNumber varchar(15) not null constraint ck_Customer_Phone_Number_is_not_blank CHECK (PhoneNumber <> ''), 
+        CustomerAddress VARCHAR(50) not null constraint ck_Customer_Address_is_not_blank CHECK (CustomerAddress <> ''), 


Address should be unique. As you can have multiple times the same customer but in different addresses.

added unique contraint

ghost · 2023-11-06T20:27:44Z

+        CustomerAddress VARCHAR(50) not null constraint ck_Customer_Address_is_not_blank CHECK (CustomerAddress <> ''), 
+        Frequency VARCHAR(9) not null  constraint ck_Customer_frequency_must_be_either_weekly_or_biweekly check (frequency in ('Weekly', 'BiWeekly')), 
+        PricePerHour int not null CONSTRAINT ck_Customer_PricePerHour_is_between_0_and_53 check (PricePerHour between 0 and 53),
+        TimeinHours int not null CONSTRAINT ck_Customer_TimeinHours_is_between_greater_than_0 check (TimeinHours >0 ),


This should have some sort of decimal place as this should be the avg hours and it can be 1.5 hours.

switched the datatype to decimal

ghost · 2023-11-06T20:28:37Z

+        Frequency VARCHAR(9) not null  constraint ck_Customer_frequency_must_be_either_weekly_or_biweekly check (frequency in ('Weekly', 'BiWeekly')), 
+        PricePerHour int not null CONSTRAINT ck_Customer_PricePerHour_is_between_0_and_53 check (PricePerHour between 0 and 53),
+        TimeinHours int not null CONSTRAINT ck_Customer_TimeinHours_is_between_greater_than_0 check (TimeinHours >0 ),
+        StartDate date not null CONSTRAINT ck_Customer_Satrt_date_is_not_blank CHECK (startdate <> ''),


Should be after company opened.

changed the constraint

ghost · 2023-11-06T20:30:35Z

+        EndDate date null, 
+        constraint ck_start_date_is_before_end_date check (StartDate < EndDate),
+        constraint ck_price_per_hour_times_hours_is_less_than_424 check (PricePerHour * TimeinHours < 424)
+)


We need a computed column that returns total per month.

added a computed column

ghost · 2023-11-06T20:45:23Z

+*/
+SELECT DeepCleanCustomers= CONCAT(c.LastName, ' ', c.FirstName, ' (',c.PhoneNumber, ') - ', (c.PricePerHour*c.TimeinHours)  )
+FROM CleaningCompany C
+where c.PricePerHour >=35 


No need for where clause as the data in table are for regular cleans only.

took out the where clause and add to the select to multiply by 1.5 to show the price would charge for a deepclean

ghost · 2023-11-06T20:46:05Z

+ORDER BY NumberOfMonths desc
+
+--3) What is the average price I ask per hour for regular cleans and what is the average price per hour for deep cleans?
+SELECT AvergaePricePerHourRegularClean = avg(c.PricePerHour)


This should be one select with 2 columns one for regular and one for deep.

but there are no deep cleans in this table?

Yes. But show how much it will be the avg price for deep cleans calculating the difference between deep and regular cleans.

ghost

Excellent improvements. See comments, fix and resubmit.

ghost · 2023-11-07T19:35:32Z

+ORDER BY NumberOfMonths desc
+
+--3) What is the average price I ask per hour for regular cleans and what is the average price per hour for deep cleans?
+SELECT AvergaePricePerHourRegularClean = avg(c.PricePerHour)


Yes. But show how much it will be the avg price for deep cleans calculating the difference between deep and regular cleans.

ghost · 2023-11-07T19:36:57Z

+        FirstName varchar(50) not null constraint ck_Customer_First_name_is_not_blank CHECK (FirstName <> ''), 
+        LastName varchar(50) not null constraint ck_Customer_Last_name_is_not_blank CHECK (LastName <> ''), 
+        PhoneNumber varchar(15) not null constraint ck_Customer_Phone_Number_is_not_blank CHECK (PhoneNumber <> ''), 
+        CustomerAddress VARCHAR(50) not null, constraint u_Customer_Address UNIQUE (CustomerAddress), constraint ck_Customer_Address_is_not_blank CHECK (CustomerAddress <> ''), 


Remove the commas between column and constraints.

ghost · 2023-11-07T19:40:39Z

+
+Alter Table Customer drop column if EXISTS TotalPerMonth
+go
+ALTER table customer add TotalPerMonth as 


Computed column can be part of table. Just do same as normal column but instead of doing ColumnName datatype do ColumnName as.

ghost · 2023-11-07T19:43:27Z

+   For this I need to see the customers phone number, last name and the amount of money they will have to pay.
+   Please do it in this format:  last name, first name (phone number) - price of service.
+*/
+SELECT DeepCleanCustomers= CONCAT(c.LastName, ' ', c.FirstName, ' (',c.PhoneNumber, ') - ', (c.PricePerHour*c.TimeinHours*1.5)  )


You didn't add the comma. And you need to add to the calculation for deep cleans that the price is 50% more but the time is also * 2.

ghost

Excellent! 100% All good.

RiFinkelstein added 11 commits November 4, 2023 22:07

deleted other scenarios

86c3a47

added database

d720355

Added files

eb4e277

added sketch

5b8a8bd

added sample data

a2d67f0

created table

7d719d2

fixed the data

083b38a

began reports

11f4a9e

continuted reports

9e89e65

finishes reports

80650bc

tested constraints

72e440a

ghost suggested changes Nov 6, 2023

View reviewed changes

RiFinkelstein added 3 commits November 6, 2023 23:37

updaes to biz-scenario

34bd319

updated bizscenario

645e36b

changed biz-scenario based on PR'

bf2de26

ghost suggested changes Nov 7, 2023

View reviewed changes

RiFinkelstein added 2 commits November 7, 2023 22:50

updated biz scenario based on PR request:

e63fbed

updated biz scenario based on PR request:

62691e9

ghost reviewed Nov 8, 2023

View reviewed changes

Conversation

RiFinkelstein commented Nov 5, 2023

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant