implemented ArmyDB#40
Open
cgblay123 wants to merge 4 commits into
Open
Conversation
ghost
suggested changes
Jan 18, 2024
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Excellent work! See comments, fix and resubmit.
| create table dbo.Soldier( | ||
| SoldierFirstName varchar(30) not null constraint c_Soldier_first_name_cannot_be_blank check(SoldierFirstName<>''), | ||
| SoldierLastName varchar(30) not null constraint c_Soldier_last_name_cannot_be_blank check(SoldierLastName<>''), | ||
| SSN char(10) not null, |
There was a problem hiding this comment.
SSN Should be in specified format. And should be unique.
| SSN char(10) not null, | ||
| DOB date not null constraint ck_Army_Soldier_DOB_must_be_at_least_17_years_ago check(datediff(year,DOB,getdate()) >= 17), | ||
| Residence varchar(25) not null constraint c_Soldier_Residence_cannot_be_blank check(Residence<>''), | ||
| EnlistmentDate date, |
There was a problem hiding this comment.
EnlistmentDate should be at the age of 17+ and cannot be in future date.
Author
There was a problem hiding this comment.
I had a constraint that should do this in DOB column
| Residence varchar(25) not null constraint c_Soldier_Residence_cannot_be_blank check(Residence<>''), | ||
| EnlistmentDate date, | ||
| ServiceUnit varchar(4) not null constraint ck_ServiceUnit_must_be_either_Navy_Land_or_Air check(ServiceUnit in('Air', 'Land', 'Navy')), | ||
| UnitRank varchar(30) not null, |
| EnlistmentDate date, | ||
| ServiceUnit varchar(4) not null constraint ck_ServiceUnit_must_be_either_Navy_Land_or_Air check(ServiceUnit in('Air', 'Land', 'Navy')), | ||
| UnitRank varchar(30) not null, | ||
| IQ int not null |
| go | ||
| set dateformat dmy | ||
|
|
||
| insert Soldier(SoldierFirstName, SoldierLastName, SSN, DOB, Residence, EnlistmentDate, ServiceUnit, UnitRank, IQ) |
There was a problem hiding this comment.
Don't allow this to insert multiple times same data.
There was a problem hiding this comment.
Can't run file multiple times. You didn't fix previous issue.
| @@ -0,0 +1,18 @@ | |||
| select * | |||
Author
|
Made changes |
ghost
suggested changes
Feb 19, 2024
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Excellent! See comments, fix and resubmit.
| SoldierFirstName varchar(30) not null constraint c_Soldier_first_name_cannot_be_blank check(SoldierFirstName<>''), | ||
| SoldierLastName varchar(30) not null constraint c_Soldier_last_name_cannot_be_blank check(SoldierLastName<>''), | ||
| SSN char(10) not null constraint u_Army_soldier_SSN_must_be_unique unique constraint c_Soldier_SSN_format check(SSN like '[1-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9]-[0-9]'), | ||
| DOB date not null constraint ck_Army_Soldier_DOB_must_be_at_least_17_years_ago check(datediff(year,DOB,getdate()) >= 17), |
There was a problem hiding this comment.
You don't need any constraint here. You need a multi column constraint for the difference between DOB and EnlistmentDate.
| SSN char(10) not null constraint u_Army_soldier_SSN_must_be_unique unique constraint c_Soldier_SSN_format check(SSN like '[1-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9]-[0-9]'), | ||
| DOB date not null constraint ck_Army_Soldier_DOB_must_be_at_least_17_years_ago check(datediff(year,DOB,getdate()) >= 17), | ||
| Residence varchar(25) not null constraint c_Soldier_Residence_cannot_be_blank check(Residence<>''), | ||
| EnlistmentDate date constraint c_Soldier_Enlistment_date_cannot_be_in_the_future check(EnlistmentDate < getdate()), |
| go | ||
| set dateformat dmy | ||
|
|
||
| insert Soldier(SoldierFirstName, SoldierLastName, SSN, DOB, Residence, EnlistmentDate, ServiceUnit, UnitRank, IQ) |
There was a problem hiding this comment.
Can't run file multiple times. You didn't fix previous issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.