Army Biz-Scenario by moshefidds · Pull Request #43 · CPU-Code-School/cpu-biz-scenario

moshefidds · 2024-02-18T02:59:56Z

No description provided.

ghost

Excellent work! See comments, fix and resubmit.

ghost · 2024-02-19T15:03:31Z

+		constraint c_Soldiers_Soldier_First_Name_cannot_be_blank check (SoldierFirstName <> ''),
+	SoldierLastName varchar(30) not null
+		constraint c_Soldiers_Soldier_Last_Name_cannot_be_blank check (SoldierLastName <> ''),
+	SSN char(10) not null


There's a much easier way to do this constraint. Use like.

Changed to like

Use SSN like [1-9][0-9]...

ghost · 2024-02-19T15:03:49Z

+			and substring(SSN, 10, 1) between 0 and 9)
+        constraint u_Soldiers_SSN unique,
+	DOB date not null,
+	PlaceOfResidence varchar(30) not null, 


Don't allow blank.

ghost · 2024-02-19T15:05:03Z

+	ServiceUnit varchar(30) not null
+		constraint c_Soldiers_Service_Unit_must_be_either_ground_land_or_air 
+		check (ServiceUnit like '%Air%' or ServiceUnit like '%Ground%' or ServiceUnit like'%Navy%'),
+	UnitRank varchar(50) not null, 


Don't allow blank.

ghost · 2024-02-19T15:05:21Z

+		constraint c_Soldiers_Service_Unit_must_be_either_ground_land_or_air 
+		check (ServiceUnit like '%Air%' or ServiceUnit like '%Ground%' or ServiceUnit like'%Navy%'),
+	UnitRank varchar(50) not null, 
+	IQlevel tinyint not null,


Don't allow 0 or negative.

ghost · 2024-02-19T15:05:40Z

+        constraint u_Soldiers_SSN unique,
+	DOB date not null,
+	PlaceOfResidence varchar(30) not null, 
+	DateOfEnlistment date not null,


Don't allow future date.

ghost · 2024-02-19T15:06:32Z

@@ -0,0 +1,12 @@
+use ArmyDB
+go


Can't run file multiple times.

Added delete

ghost · 2024-02-19T15:08:57Z

+order by s.IQlevel desc
+
+--2) I need a list of all soldiers sorted by age at enlistment from high to low. Do not include columns that are not relevant to this list.
+select s.DOB, s.DateOfEnlistment, Age = datediff(year,s.DOB,s.DateOfEnlistment)


Show the names etc. The things not relevant are IQ level, place of residence, unit etc.

Added relevant columns

moshefidds

Updated requested corrections
Thanks

moshefidds · 2024-02-22T03:35:55Z

@@ -0,0 +1,12 @@
+use ArmyDB
+go


Added delete

moshefidds · 2024-02-22T04:21:22Z

+		constraint c_Soldiers_Soldier_First_Name_cannot_be_blank check (SoldierFirstName <> ''),
+	SoldierLastName varchar(30) not null
+		constraint c_Soldiers_Soldier_Last_Name_cannot_be_blank check (SoldierLastName <> ''),
+	SSN char(10) not null


Changed to like

moshefidds · 2024-02-22T04:22:40Z

+			and substring(SSN, 10, 1) between 0 and 9)
+        constraint u_Soldiers_SSN unique,
+	DOB date not null,
+	PlaceOfResidence varchar(30) not null, 


moshefidds · 2024-02-22T04:26:11Z

+        constraint u_Soldiers_SSN unique,
+	DOB date not null,
+	PlaceOfResidence varchar(30) not null, 
+	DateOfEnlistment date not null,


moshefidds · 2024-02-22T04:27:31Z

+	ServiceUnit varchar(30) not null
+		constraint c_Soldiers_Service_Unit_must_be_either_ground_land_or_air 
+		check (ServiceUnit like '%Air%' or ServiceUnit like '%Ground%' or ServiceUnit like'%Navy%'),
+	UnitRank varchar(50) not null, 


moshefidds · 2024-02-22T04:29:18Z

+		constraint c_Soldiers_Service_Unit_must_be_either_ground_land_or_air 
+		check (ServiceUnit like '%Air%' or ServiceUnit like '%Ground%' or ServiceUnit like'%Navy%'),
+	UnitRank varchar(50) not null, 
+	IQlevel tinyint not null,


moshefidds · 2024-02-22T04:37:46Z

+order by s.IQlevel desc
+
+--2) I need a list of all soldiers sorted by age at enlistment from high to low. Do not include columns that are not relevant to this list.
+select s.DOB, s.DateOfEnlistment, Age = datediff(year,s.DOB,s.DateOfEnlistment)


Added relevant columns

ghost

Excellent! 100% All good.

ghost · 2024-02-22T15:21:11Z

+		constraint c_Soldiers_Soldier_First_Name_cannot_be_blank check (SoldierFirstName <> ''),
+	SoldierLastName varchar(30) not null
+		constraint c_Soldiers_Soldier_Last_Name_cannot_be_blank check (SoldierLastName <> ''),
+	SSN char(10) not null


Use SSN like [1-9][0-9]...

moshefidds added 3 commits February 15, 2024 08:50

chose scenario and added folders

38e544f

initial table file added

c16086b

completed table, data, reports and tests

66705c0

ghost suggested changes Feb 19, 2024

View reviewed changes

moshefidds commented Feb 22, 2024

View reviewed changes

Submission CPU-Code-School#2

a848106

ghost reviewed Feb 22, 2024

View reviewed changes

Conversation

moshefidds commented Feb 18, 2024

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

moshefidds left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant