I did the work for the Army biz scenario by ChanaCohen3896 · Pull Request #44 · CPU-Code-School/cpu-biz-scenario

ChanaCohen3896 · 2024-02-26T21:37:55Z

No description provided.

ghost

Excellent work! See comments, fix and resubmit.

ghost · 2024-02-27T16:48:09Z

+        constraint c_Soldiers_soldier_last_name_cannot_be_blank check(SoldierLastName <> ''),
+    SoldierFirstName varchar(25) not null
+        constraint c_Soldiers_soldier_first_name_cannot_be_blank check(SoldierFirstName <> ''),
+    SoldierSSN char(10) not null


SSN must be in specific format. It should be 8 digits followed by a hyphen followed by one digit.

done. I deleted the not blank constraint also.

ghost · 2024-02-27T16:49:12Z

+        constraint c_Soldiers_soldier_SSN_cannot_be_blank check(SoldierSSN <> '')
+        constraint u_Soldiers_soldier_SSN_ unique,
+    SoldierDOB date not null
+        constraint c_Soldiers_soldier_DOB_cannot_be_blank check(SoldierDOB <> ''),


Why don't you allow a soldier to be born on 01/01/1900? This is the date returned from a blank date.

I deleted the DOB cannot be blank constraint

ghost · 2024-02-27T16:52:50Z

+    SoldierRank varchar(25) not null 
+        constraint c_Soldier_soldier_rank_cannot_be_blank check(SoldierRank <> ''),
+    SoldierIQ int not null 
+        constraint c_Soldiers_soldier_IQ_cannot_be_blank check(SoldierIQ <> ''),


I'm confused here. Do you allow 0 IQ? This constraint blocks 0 but the next one allows.

Why do you even have this constraint? This is a int column and this constraint is for varchars.

I deleted the not blank constraint.

ghost · 2024-02-27T16:53:06Z

+        constraint c_Soldier_soldier_rank_cannot_be_blank check(SoldierRank <> ''),
+    SoldierIQ int not null 
+        constraint c_Soldiers_soldier_IQ_cannot_be_blank check(SoldierIQ <> ''),
+        constraint c_Soldiers_soldier_IQ_cannot_be_negative check(SoldierIQ >= 0),


You should not allow 0.

Ok I switched this constraint to soldier IQ must be greater than 0.

ghost · 2024-02-27T16:54:53Z

+    SoldierIQ int not null 
+        constraint c_Soldiers_soldier_IQ_cannot_be_blank check(SoldierIQ <> ''),
+        constraint c_Soldiers_soldier_IQ_cannot_be_negative check(SoldierIQ >= 0),
+    SoldierAgeAtEnlistment as datepart(year, SoldierDateOfEnlistment) - datepart(year, SoldierDOB) persisted not null,


Tip: Use datediff(). You don't need the extra not null constraint, both columns don't allow null and this is a computed column.

Thanks I fixed it.

ghost · 2024-02-27T16:56:14Z

+        constraint c_Soldiers_soldier_IQ_cannot_be_blank check(SoldierIQ <> ''),
+        constraint c_Soldiers_soldier_IQ_cannot_be_negative check(SoldierIQ >= 0),
+    SoldierAgeAtEnlistment as datepart(year, SoldierDateOfEnlistment) - datepart(year, SoldierDOB) persisted not null,
+        constraint c_Soldiers_soldier_date_of_enlistment_cannot_be_before_17_years_after_soldier_DOB check(datepart(year, SoldierDateOfEnlistment) >= datepart(year, SoldierDOB) + 17)


This can be a constraint on the computed column not to allow an age less than 17.

Ok thank you. I fixed it.

ghost · 2024-02-27T16:57:25Z

+   (This should be done by using a union select and adding a literal column for year range.)
+*/
+
+select concat('2017-2019', ' ', s.SoldierFirstName, ' ', s.SoldierLastName, ' - ', s.SoldierSSN, ' (', s.SoldierDateOfEnlistment, ')', ', ', s.ServiceUnit)


Add column name.

ghost · 2024-02-27T16:57:42Z

+
+select concat('2017-2019', ' ', s.SoldierFirstName, ' ', s.SoldierLastName, ' - ', s.SoldierSSN, ' (', s.SoldierDateOfEnlistment, ')', ', ', s.ServiceUnit)
+from Soldiers s
+where datepart(year, s.SoldierDateOfEnlistment) between 2017 and 2019


Tip: Use year() function.

ChanaCohen3896

Hi, I went through all the comments and fixed the table and reports.

ChanaCohen3896 · 2024-02-27T17:08:55Z

+   (This should be done by using a union select and adding a literal column for year range.)
+*/
+
+select concat('2017-2019', ' ', s.SoldierFirstName, ' ', s.SoldierLastName, ' - ', s.SoldierSSN, ' (', s.SoldierDateOfEnlistment, ')', ', ', s.ServiceUnit)


ChanaCohen3896 · 2024-02-27T17:09:42Z

+
+select concat('2017-2019', ' ', s.SoldierFirstName, ' ', s.SoldierLastName, ' - ', s.SoldierSSN, ' (', s.SoldierDateOfEnlistment, ')', ', ', s.ServiceUnit)
+from Soldiers s
+where datepart(year, s.SoldierDateOfEnlistment) between 2017 and 2019


ChanaCohen3896 · 2024-02-27T17:36:30Z

+        constraint c_Soldiers_soldier_last_name_cannot_be_blank check(SoldierLastName <> ''),
+    SoldierFirstName varchar(25) not null
+        constraint c_Soldiers_soldier_first_name_cannot_be_blank check(SoldierFirstName <> ''),
+    SoldierSSN char(10) not null


done. I deleted the not blank constraint also.

ChanaCohen3896 · 2024-02-27T17:37:07Z

+        constraint c_Soldiers_soldier_SSN_cannot_be_blank check(SoldierSSN <> '')
+        constraint u_Soldiers_soldier_SSN_ unique,
+    SoldierDOB date not null
+        constraint c_Soldiers_soldier_DOB_cannot_be_blank check(SoldierDOB <> ''),


I deleted the DOB cannot be blank constraint

ChanaCohen3896 · 2024-02-27T17:38:40Z

+    SoldierRank varchar(25) not null 
+        constraint c_Soldier_soldier_rank_cannot_be_blank check(SoldierRank <> ''),
+    SoldierIQ int not null 
+        constraint c_Soldiers_soldier_IQ_cannot_be_blank check(SoldierIQ <> ''),


I deleted the not blank constraint.

ChanaCohen3896 · 2024-02-27T17:39:32Z

+        constraint c_Soldier_soldier_rank_cannot_be_blank check(SoldierRank <> ''),
+    SoldierIQ int not null 
+        constraint c_Soldiers_soldier_IQ_cannot_be_blank check(SoldierIQ <> ''),
+        constraint c_Soldiers_soldier_IQ_cannot_be_negative check(SoldierIQ >= 0),


Ok I switched this constraint to soldier IQ must be greater than 0.

ChanaCohen3896 · 2024-02-27T17:41:26Z

+    SoldierIQ int not null 
+        constraint c_Soldiers_soldier_IQ_cannot_be_blank check(SoldierIQ <> ''),
+        constraint c_Soldiers_soldier_IQ_cannot_be_negative check(SoldierIQ >= 0),
+    SoldierAgeAtEnlistment as datepart(year, SoldierDateOfEnlistment) - datepart(year, SoldierDOB) persisted not null,


Thanks I fixed it.

ChanaCohen3896 · 2024-02-27T17:44:13Z

+        constraint c_Soldiers_soldier_IQ_cannot_be_blank check(SoldierIQ <> ''),
+        constraint c_Soldiers_soldier_IQ_cannot_be_negative check(SoldierIQ >= 0),
+    SoldierAgeAtEnlistment as datepart(year, SoldierDateOfEnlistment) - datepart(year, SoldierDOB) persisted not null,
+        constraint c_Soldiers_soldier_date_of_enlistment_cannot_be_before_17_years_after_soldier_DOB check(datepart(year, SoldierDateOfEnlistment) >= datepart(year, SoldierDOB) + 17)


Ok thank you. I fixed it.

ghost

Excellent! 100% All good.

I did the work for the Army biz scenario

c5a39fe

ghost suggested changes Feb 27, 2024

View reviewed changes

ChanaCohen3896 commented Feb 27, 2024

View reviewed changes

CPU-Code-School#22 Part 1 - Session 20B HW fixed

70742cb

ghost reviewed Feb 28, 2024

View reviewed changes

Conversation

ChanaCohen3896 commented Feb 26, 2024

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ChanaCohen3896 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant