generated from CSES-UCSD/nextjs-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 0
Completing REST endpoints for GET all and POST #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Amormio25
wants to merge
1
commit into
main
Choose a base branch
from
listings-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| import { NextResponse } from "next/server"; | ||
| import { connectToDatabase } from "@/lib/mongoose"; | ||
| import { z } from "zod"; | ||
| import Listing from "@/models/Listing"; | ||
|
|
||
| // test comment | ||
| // ask about whether users should provide _id, that seems more like a | ||
| // server task, the rest they should be able to | ||
| const listingValidationSchema = z.object({ | ||
| _id: z.string().min(1), | ||
| itemId: z.string().min(1), | ||
| labId: z.string().min(1), | ||
| quantityAvailable: z.number().min(0), // can list items with 0 quantity? | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should have items listed with min of 1 quantity |
||
| createdAt: z | ||
| .string() | ||
| // could possibly change to MM-DD-YYYY | ||
| .regex(/^\d{4}-\d{2}-\d{2}$/, "Invalid date format. Expected YYYY-MM-DD."), | ||
| }); | ||
|
|
||
| async function connect() { | ||
| try { | ||
| await connectToDatabase(); | ||
| } catch { | ||
| return NextResponse.json( | ||
| { success: false, message: "Error connecting to database" }, | ||
| { status: 500 } | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| // get all | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: method headers should have a detailed comment about what it does. What is the input? output? |
||
| async function GET() { | ||
| const connectionResponse = await connect(); | ||
| if (connectionResponse) return connectionResponse; | ||
|
|
||
| try { | ||
| const listings = await Listing.find(); | ||
| return NextResponse.json( | ||
| { success: true, data: listings }, | ||
| { status: 200 } | ||
| ); | ||
| } catch (error) { | ||
| return NextResponse.json( | ||
| { success: false, message: "Error occurred while retrieving listings." }, | ||
| { status: 500 } | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| // post all | ||
| async function POST(request: Request) { | ||
| const connectionResponse = await connect(); | ||
| if (connectionResponse) return connectionResponse; | ||
|
|
||
| // assuming frontend sends req with content-type set to app/json | ||
| // content type automatically set as app/json | ||
| const body = await request.json(); | ||
| const parsedBody = listingValidationSchema.safeParse(body); | ||
|
|
||
| if (!parsedBody.success) { | ||
| return NextResponse.json( | ||
| { | ||
| success: false, | ||
| message: "Invalid request body.", | ||
| // error: parsedBody.error.format(), don't expose error? | ||
| }, | ||
| { status: 400 } | ||
| ); | ||
| } | ||
|
|
||
| try { | ||
| const listing = await Listing.create(parsedBody.data); | ||
| return NextResponse.json( | ||
| { | ||
| success: true, | ||
| message: "Successfully created new listing.", | ||
| data: listing, | ||
| }, | ||
| { status: 201, headers: { Location: `/app/listings/${listing._id}` } } | ||
| // resource will be retrievable at this url | ||
| ); | ||
| } catch (error: any) { | ||
| if (error.code === 11000) { | ||
| return NextResponse.json( | ||
| // don't send mongo's error - exposes design info | ||
| { success: false, message: "This listing already exists." }, | ||
| { status: 409 } | ||
| ); | ||
| } | ||
| return NextResponse.json( | ||
| { success: false, message: "Error occurred while creating new listing." }, | ||
| { status: 500 } | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| export { GET, POST }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't include _id field since MongoDB will automatically generate and it is a db thing. I was a bit unclear in the task description, but yes, we shouldn't have a id field.