Skip to content

fix: use the node name to find the compilation output #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drothenberger wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use the node name to find the compilation output #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions esphome_selective_updates/esphome_smart_updater.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,8 @@ def needs_update(device_name: str, progress: Dict) -> Tuple[bool, str]:
def compile_in_esphome_container(
container: str,
yaml_name: str,
device_name: str
device_name: str,
node: str
) -> Optional[str]:
"""
Compile firmware in ESPHome container
Expand All @@ -428,8 +429,8 @@ def compile_in_esphome_container(

# Locate compiled binary
stem = Path(yaml_name).stem
pio_bin = f"/data/build/{stem}*/.pioenvs/{stem}*/firmware.bin"
legacy = f"/config/esphome/.esphome/build/{stem}/{stem}.bin"
pio_bin = f"/data/build/{node}*/.pioenvs/{node}*/firmware.bin"
legacy = f"/config/esphome/.esphome/build/{node}/{node}.bin"

dst_dir = Path("/config/esphome/builds")
dst_dir.mkdir(parents=True, exist_ok=True)
Expand Down Expand Up @@ -794,7 +795,7 @@ def update_device(
log(f"→ Starting update for {name}")

# Compile
bin_path = compile_in_esphome_container(container, yaml_name, name)
bin_path = compile_in_esphome_container(container, yaml_name, name, node)
if STOP_REQUESTED:
log("Stop requested during compile")
return "skipped"
Expand Down